-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electric Vehicles #1299
Open
aspeake
wants to merge
70
commits into
develop
Choose a base branch
from
electric_vehicles
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Electric Vehicles #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…60006 1e89f060006 Latest results. 357509ed95c fixes for timeseries tests of EVs ed8cc5b1c92 Merge remote-tracking branch 'origin/master' into ev_batteries 14f026ec7b2 address unit test failures for EV batteries aaecf51607c update in-line documentation for vehicles and batteries 52d07ddf3fa Fix unit tests for EV batteries d591cad7673 Merge remote-tracking branch 'origin/master' into ev_batteries a5a3fc7fa95 Fix merge conflict 7d04943785b Pull in latest HPXML schema for EVs ea3d06f2f61 Merge remote-tracking branch 'origin/master' into ev_batteries d0a554f749d Apply rubocop b2d226a606e Fix bug iniitalizing DBT sensor 2bfc0f7b238 Fix for EV discharge offset object when EV location is garage 3291f9c659a Write EV fraction charged at home to HPXML 891f6095af3 Introduce miles/yr and hours/wk arguments for EVs, calculate the effective discharge power 0c8861cf6e2 Pull in latest Vehicles changes in HPXML schema, update HPXML classes as needed; expose fuel economy and vehicle miles traveled args 9c31908f129 Merge remote-tracking branch 'origin/master' into ev_batteries 2432bfb168d EMS program to adjust effective EV discharge power and offset that discharge power for reporting a4135347c87 Update reporting measure to output EV energy b1ef026fc63 Generate an ELCD object for each EV battery 5d21e323428 Update EV arguments for latest approach to argument handling 3228c7ae14c Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries b86a506dbef Merge remote-tracking branch 'origin/master' into ev_batteries e279ea4426b Latest results. cefa4e28739 Merge remote-tracking branch 'origin/master' into ev_batteries 35e8be48fd7 fix failing tests for ev batteries bd3fbfe6f4e Merge remote-tracking branch 'origin/master' into ev_batteries 6fbd4f57cc1 update unit tests for EVs and chargers; apply rubocop 1effbc82974 Merge remote-tracking branch 'origin/master' into ev_batteries f6b88a304f9 Refine inputs for EV battery and charger, update tests 0056e2c66d9 Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries 22f00b2e2fe Merge remote-tracking branch 'origin/master' into ev_batteries 61d39b67361 Seperate EVs from batteries and leverage existing EV charger fields dd4d5cfffa7 Merge remote-tracking branch 'origin/master' into ev_batteries 2a9b7bb6708 Latest results. 374aae8500f fix test for battery log message 357ba18deca Merge remote-tracking branch 'origin/master' into ev_batteries da8dc17703f update log message tests for batteries 9db3aebb317 add missing ev battery schedule for tests 52bc3ab47b4 Merge remote-tracking branch 'origin/master' into ev_batteries 8f33e3d0556 initial tests for ev batteries 01437d08f71 always require schedule when modeling ev batteries 5c36fcb1483 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries 210c463549c make ev_battery_preset argument optional 4f1a37e0f81 update how battery ids are assigned in xml 744ad6638cf stub out defaults for EV batteries 3f943741530 allow one EV and one non-EV battery in schema 08c8c5a2b69 fix ev battery schedule generation, generalize for ev and non-ev battery schedules 36492fbf179 custom schedule columns for EV batteries 7b651b01367 new arguments and method to write EV battery to xml git-subtree-dir: resources/hpxml-measures git-subtree-split: 1e89f0600061f49f1f4e0be26942858e5d90a7c5
aspeake
force-pushed
the
electric_vehicles
branch
from
September 13, 2024 21:06
be3b260
to
dddbc62
Compare
…ed6cc d78b0aed6cc Merge remote-tracking branch 'origin/ev_batteries' into ev_schedules 8cc6c937dbd Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries 50a8c47d638 prevent EVs modeled with a plug load and a battery at the same time 25d24d5a84f Merge branch 'ev_batteries' into ev_schedules fd0dd492dee Binary occupancy d08ba63913f Merge branch 'ev_batteries' into ev_schedules d44e1bcfea4 Handle schedule conflict ce9ff761e00 Merge branch 'ev_batteries' into ev_schedules d377d3c6789 Merge branch 'ev_batteries' into ev_schedules d5db465f20a Fix test and read from HPXML be21d3c0211 Merge branch 'ev_batteries' into ev_schedules 19740a71b27 Generate EV schedules git-subtree-dir: resources/hpxml-measures git-subtree-split: d78b0aed6cce2e67bae77126c5783241a8f1e415
…0ad39 5230cc0ad39 fix bug from merge conflict git-subtree-dir: resources/hpxml-measures git-subtree-split: 5230cc0ad39df0e4794a1c1a55ae1ea7ccc988cd
3c867be6e4 Remove epw arguments git-subtree-dir: resources/hpxml-measures git-subtree-split: 3c867be6e4a3fbc671a8dabf85e01189c014dc1f
b102371faf Handle hours per week git-subtree-dir: resources/hpxml-measures git-subtree-split: b102371faf29325d2967920f46c36dba8496c20e
d15baa1866 Output EV occupant occupancy git-subtree-dir: resources/hpxml-measures git-subtree-split: d15baa1866321e9a58fa38b483040e602a785863
aspeake
force-pushed
the
electric_vehicles
branch
from
November 21, 2024 23:16
f86ccca
to
3e3746f
Compare
aspeake
force-pushed
the
electric_vehicles
branch
from
November 21, 2024 23:17
3e3746f
to
5949046
Compare
…6187f 313b6d6187f Add unavailable periods entry for new columns bcd352f0780 Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_schedules e0b8da9beed Latest results. 0c5982fbaa4 Fixed CI failure? And some code cleanup. dae014e1e9b A little cleanup. e461f260d02 Fixed CI failures? 81fa92849e4 Accommodate new output. 1c202296c81 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries 57e820f750b Update measures, fix CI error. 3b7dabd640c Merge pull request #1895 from NREL/docs_water_heater 8068f153d26 Add Model.add_plant_loop() method. 2b64d9f800d Bugfix. f7e65bee01b Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into docs_water_heater 926c3dedc72 Added ruby documentation to waterheater.rb. b5d8972e74c Bump version back to 1.10.0. 94d6687c2d4 Merge pull request #1891 from NREL/manual_j_more_improvements 59d9cdbac67 Update measure 172416f362c Switch version to 1.9.1 for release. Update docs/readme/changelog. f206771b045 Latest results. 5e6784b5d5f Merge branch 'manual_j_more_improvements' of https://github.com/NREL/OpenStudio-HPXML into manual_j_more_improvements 72c55f7e733 fix bug while cleaningup 024d5007bf2 Latest results. ee5e87e82ae Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into manual_j_more_improvements 0d1232c0164 Merge branch 'manual_j_more_improvements' of https://github.com/NREL/OpenStudio-HPXML into manual_j_more_improvements ac134c96f3a 3-23 crawlspace wall height change 09fb00ce9e0 Merge pull request #1892 from NREL/buildreshpxml_docs_version d968043c486 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into buildreshpxml_docs_version 5d3eeae5543 Always load EV discharge energy variable to adjust electricity meter. 1066943a60d Merge pull request #1894 from NREL/misc_refactor_cleanup d250e338677 Latest results. 3dc5f7e3ddf Missed one more. dc4ecf707e8 Latest results. 13984347ef6 Merge branch 'misc_refactor_cleanup' of https://github.com/NREL/OpenStudio-HPXML into misc_refactor_cleanup 0d3207df51b Bugfix. d08d7b63111 Latest results. 3c7fcabee23 Revert change. c8573ecfc8a Bugfix. 37732581d28 Misc refactor/cleanup and minor bugfixes. Updates HPXML::has_fuels() to traverse the HPXML object for performance reasons (particularly important when running whole SFA/MF buildings). d0bbdd47ae3 Add check to avoid always trying to report unmet driving hours 8b29eabca5c New EMS variable to track unmet driving hours, report with Vehicle Type outputs. db788d3286f Adds a test to ensure BuildResidentialHPXML measure docs links are updated when the OS-HPXML version is bumped. 08673f55c68 Latest results. 65d756929a5 fix typo c5831f52e61 minor improvements git-subtree-dir: resources/hpxml-measures git-subtree-split: 313b6d6187f0ba1338bfdc29a8122af4065236ce
…8916f 40ad8e8916f Merge branch 'ev_batteries' into ev_schedules d44ac9962b0 Fix incorrect if statement in resilience reporting. 2292c06fd4c Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries 4776c31c92f Update docs and inline comments for EVs and chargers; remove roundtrip EV efficiency argument; update some constants. 9af936f2dd6 Latest results. 922cdea3e14 Ensure only one EV ruleset charging or discharging schedule is generated. 83d9148fb72 Refactor calculation of effective and rated EV discharge power. Update default EV schedules. b8c6ab50cc6 Clarify argument descriptions for EV battery and EV plug load. 2c84e016d0c Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries 23edb3036e0 Move logic to request EV discharge energy output; throw warning for unmet driving hours. c27fde0509a Latest results. f0976f03710 Merge remote-tracking branch 'origin/master' into ev_batteries 8c2772e0fd3 Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries d16f0d11db1 Drop vehicle type output and move unmet driving hours to UHT; add test for EV with unmet hours. 34fce414bfd Merge pull request #1901 from NREL/update_measure d53251ab910 Merge pull request #1899 from NREL/whole-mf-bldg-zero-occupants 0d18829ab62 Use an md5hash instead to prevent confusion of having two version.rb files. 627e9dcfa03 Ensure BuildResidentialHPXML measure.xml and README.md are updated when the OS-HPXML version is bumped. a6fbda7fa50 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into whole-mf-bldg-zero-occupants c38762eb90a Clarify CFIS definition [ci skip] 1ef1104323b Merge pull request #1896 from NREL/schedule_file_interpolation 934ddf42a93 Fix test. 4616266ebf4 Exclude pool/spa and include ceiling fan to match previous implementation. e3547344d9a Merge branch 'whole-mf-bldg-zero-occupants' of https://github.com/NREL/OpenStudio-HPXML into whole-mf-bldg-zero-occupants 2ca07befda7 Bugfixes and more tests. 01b93fb883c Latest results. b17f24ee768 Fix ASHRAE 140 runs. 30da3d89f41 Allow override when duplicate column names exist. 11506406987 Fill in function signatures bc1e205023d Fixes zero occupants specified for one unit in a whole MF building from being treated like zero occupants for every unit. 71cdc88d73a Latest results. 22344b0e81a Set EV rated power output during model generation using miles, hours, and efficiency. 859d4f51289 Merge branch 'ev_batteries' of https://github.com/NREL/OpenStudio-HPXML into ev_batteries 4cdcad3b0de Add schematron rules for EVs; drop discharge power input for EVs. 2444574cec6 Merge pull request #1898 from NREL/hers_outputs 794e01b33b9 Latest results. 2f1718ddbc3 Updates HERS test outputs (units, order of files) to match latest RESNET accreditation forms. 88c827785ea Update changelog and measure.xml [ci skip] 2f42aaba489 Latest results. cca5c80a004 Bugfix for when a detailed schedule is used with higher resolution (e.g., 10-min data) than the simulation timestep (e.g., 60-min). 2d8bf015b62 Remove some unused code I noticed in tasks.rb [ci skip] git-subtree-dir: resources/hpxml-measures git-subtree-split: 40ad8e8916f5dc8ee2bf3a36a9fef43900485eb4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Introduce EVs, including vehicle and charging stock characterization, EV battery modeling updates, and charging schedule generation.
Companion PRs:
Checklist
Not all may apply:
openstudio tasks.rb update_measures
has been run