prototype cryostat auto #4
Conversation
startup/11-temperature-controller.py
Outdated
| @@ -46,6 +46,7 @@ def set(self, *args, **kwargs): | |||
| write_pv='XF:28IDC-ES:1{Env:04}T-SP', | |||
| tolerance= 3, name='eurotherm') | |||
| """ | |||
| heater_dict = {(4, 100): 0, (100, 200): 1, (200, 300): 2} | |||
There was a problem hiding this comment.
This needs real values.
| if self.auto: | ||
| for (low, hi), heater_pos in heater_dict.items(): | ||
| if low < pos <= hi: | ||
| self.heater.set(heater_pos) |
There was a problem hiding this comment.
you should wait on the status object returned here, or AND it with the returned status object
There was a problem hiding this comment.
feel free to push to this branch. I've already exceeded my knowledge of how things work!
|
Attn: @awalter-bnl @tacaswell @mrakitin @stuartcampbell (Please feel free to rope more people in) |
|
What is the purpose of this, and why are we pushing this now on a friday evening. |
|
This correctly sets the heater level based off the requested temperature. As to why this is happening friday night, well... you know how these things happen. |
|
Why are we setting the heater level in ophyd and not in the IOC ? I thought @awalter-bnl and @milinda2014 discussed this and it was going to be done in the IOC so it will be consistent from CSS and bluesky ? |
|
I would love for this to be done in the ioc. What is the time frame on that? |
|
Controls group thinks this should be done at the ophyd layer.
M
…Sent from my iPhone
On Jul 13, 2018, at 7:02 PM, Christopher J. Wright <[email protected]<mailto:[email protected]>> wrote:
I would love for this to be done in the ioc. What is the time frame on that?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#4 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AFyWVAsNImh30FapPxJ3LvVrH3mqyjApks5uGScPgaJpZM4VPhc6>.
|
|
@milinda2014 what do you mean? This is at the ophyd layer? |
ENH: Add sample stage stack axes ophyd obj
No description provided.