-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mypy typing #87
base: main
Are you sure you want to change the base?
Mypy typing #87
Conversation
Well this PR ended up being a lot bigger than expected and there is a lot more typing work to do. Mypy officially passes without errors, however, a lot of functions are ignored because their signatures are untyped. Merging this PR as-is should be fine (once all tests pass). Future & smaller typing improvements can be worked on separately. I used this issue to learn a lot more about the codebase and try to understand all of the moving parts. I think there are a lot of opportunities to simplify the code, document the interactions of the various moving pieces, and have much broader test coverage. I'll open tickets for each of these so we can begin to make progress here. |
Also, due to dependency issues, I've moved |
This PR adds type hints in as many places as I could.
Through this effort, I discovered that there is a good amount of simplification that can be done to make the code more flexible/maintainable going forward. It's outside the scope of this PR but it can be done in concrete chunks!
Closes #85