Skip to content

Commit

Permalink
Change model call default arg values to None instead of bool vals
Browse files Browse the repository at this point in the history
This fixes an issue with model saving where the concrete function
cannot be matched correctly
  • Loading branch information
oliverholworthy committed Oct 17, 2023
1 parent ba1b775 commit b81bf37
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion merlin/models/tf/models/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1798,7 +1798,7 @@ def build(self, input_shape=None):

self.built = True

def call(self, inputs, targets=None, training=False, testing=False, output_context=False):
def call(self, inputs, targets=None, training=None, testing=None, output_context=None):
"""
Method for forward pass of the model.
Expand All @@ -1820,6 +1820,9 @@ def call(self, inputs, targets=None, training=False, testing=False, output_conte
Tensor or tuple of Tensor and ModelContext
Output of the model, and optionally the context
"""
training = training or False
testing = testing or False
output_context = output_context or False
outputs = inputs
features = self._prepare_features(inputs, targets=targets)
if isinstance(features, tuple):
Expand Down

0 comments on commit b81bf37

Please sign in to comment.