Warp Perspective CPU Impl #5829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with device type. Signed-off-by: Bryce Ferenczi <[email protected]>
Signed-off-by: Bryce Ferenczi <[email protected]>
mzient
reviewed
Feb 24, 2025
mzient
reviewed
Feb 24, 2025
Signed-off-by: Bryce Ferenczi <[email protected]>
|
!build |
|
CI MESSAGE: [24531891]: BUILD STARTED |
klecki
approved these changes
Feb 25, 2025
|
CI MESSAGE: [24531891]: BUILD PASSED |
rostan-t
approved these changes
Feb 26, 2025
|
@5had3z thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
CPU Implementation was missing from fn.experimental.warp_perspective. This PR plugs that hole, using cv::warpPerspective, with the same API as the CV-CUDA impl.
Additional information:
Affected modules and functionalities:
fn.experimental.warp_perspective
Key points relevant for the review:
I'm not sure how to properly share the same class template between the two implementations, WarpPerspecive inherits from nvcvop::NVCVSequenceOperator which sets GPUBackend. Maybe there is a nicer way to combine the two of them.
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A