Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tensor_shape.h warning fix #5831

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

jantonguirao
Copy link
Contributor

Category:

Bug fix / Other

Description:

Fixes compile warning

#14 1030.7 In member function ‘void dali::TensorListShapeBase<Derived, sample_ndim>::set_tensor_shape(int64_t, const SampleShape&) [with SampleShape = dali::TensorShape<0>; Derived = dali::TensorListShape<>; int sample_ndim = -1]’,
#14 1030.7     inlined from ‘void dali::NumpyReaderGPU::RunImplTyped(dali::Workspace&) [with T = bool; int Dims = 0]’ at /opt/dali/dali/operators/reader/numpy_reader_gpu_op_impl.cu:151:30:
#14 1030.7 /opt/dali/include/dali/core/tensor_shape.h:649:20: warning: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ reading between 8 and 17179869176 bytes from a region of size 1 [-Wstringop-overflow=]
#14 1030.7   649 |       shapes[base + i] = sample_shape[i];

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@jantonguirao jantonguirao marked this pull request as ready for review February 26, 2025 16:44
@jantonguirao
Copy link
Contributor Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24613173]: BUILD STARTED

@JanuszL JanuszL self-assigned this Feb 26, 2025
Signed-off-by: Joaquin Anton Guirao <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24623391]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [24623391]: BUILD PASSED

@mzient mzient assigned mzient and unassigned banasraf Feb 28, 2025
@jantonguirao jantonguirao merged commit 63c0541 into NVIDIA:main Mar 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants