Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add existing code for kmeans #3210

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Add existing code for kmeans #3210

merged 6 commits into from
Feb 13, 2025

Conversation

nvkevlu
Copy link
Collaborator

@nvkevlu nvkevlu commented Feb 7, 2025

Add existing code for kmeans.

Description

Add existing code for kmeans.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@nvkevlu nvkevlu requested a review from ZiyueXu77 February 7, 2025 01:34
ZiyueXu77
ZiyueXu77 requested changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will work on KMeans updates and then you can update this tutorial accordingly

@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Feb 10, 2025

I will work on KMeans updates and then you can update this tutorial accordingly

Great, thank you!

@ZiyueXu77
Copy link
Collaborator

KMeans updated in this PR #3217

@nvkevlu nvkevlu enabled auto-merge (squash) February 13, 2025 21:27
@nvkevlu
Copy link
Collaborator Author

nvkevlu commented Feb 13, 2025

/build

@nvkevlu nvkevlu merged commit 455bea5 into NVIDIA:main Feb 13, 2025
20 checks passed
@nvkevlu nvkevlu deleted the add_kmeans_dli branch February 13, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZiyueXu77 ZiyueXu77 ZiyueXu77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvkevlu @ZiyueXu77