Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate xgboost examples #3214

Merged
merged 9 commits into from
Feb 14, 2025
Merged

Consolidate xgboost examples #3214

merged 9 commits into from
Feb 14, 2025
+780 −1,623

Conversation

ZiyueXu77
Copy link
Collaborator

Fixes # .

Description

Combine three xgboost example folders to one and reorganize, migrate from job templates to job API

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

@ZiyueXu77 ZiyueXu77 marked this pull request as draft February 7, 2025 22:32
@ZiyueXu77 ZiyueXu77 marked this pull request as ready for review February 10, 2025 20:41
@ZiyueXu77 ZiyueXu77 requested a review from nvkevlu February 10, 2025 22:32
YuanTingHsieh
YuanTingHsieh reviewed Feb 13, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the effort to consolidate them! We need to check through all our examples and remove old usage of XGBoost code (the "V1") later

nvflare/app_opt/psi/dh_psi/dh_psi_task_handler.py Show resolved Hide resolved
examples/advanced/xgboost/fedxgb/xgb_fl_job_horizontal.py Show resolved Hide resolved
examples/advanced/xgboost/README.md Outdated Show resolved Hide resolved
examples/advanced/xgboost/fedxgb/README.md Show resolved Hide resolved
examples/advanced/xgboost/fedxgb/README.md Show resolved Hide resolved
@ZiyueXu77 ZiyueXu77 enabled auto-merge (squash) February 14, 2025 00:15
@ZiyueXu77
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Feb 14, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@ZiyueXu77 ZiyueXu77 merged commit 583daeb into NVIDIA:main Feb 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@SYangster SYangster Awaiting requested review from SYangster

@nvidianz nvidianz Awaiting requested review from nvidianz

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZiyueXu77 @YuanTingHsieh