Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add devN to semver #401

Merged
merged 3 commits into from
Nov 17, 2024
Merged

chore: Add devN to semver #401

merged 3 commits into from
Nov 17, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 13, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g requested a review from terrykong November 13, 2024 08:15
Signed-off-by: Oliver Koenig <[email protected]>
@ko3n1g ko3n1g marked this pull request as ready for review November 14, 2024 09:43
@ko3n1g ko3n1g added the Run CICD Set + un-set to retrigger label Nov 14, 2024
@ko3n1g ko3n1g enabled auto-merge (squash) November 14, 2024 09:45
@ko3n1g ko3n1g marked this pull request as draft November 14, 2024 14:01
auto-merge was automatically disabled November 14, 2024 14:01

Pull request was converted to draft

@ko3n1g ko3n1g marked this pull request as ready for review November 17, 2024 18:15
@ko3n1g ko3n1g enabled auto-merge (squash) November 17, 2024 21:38
@ko3n1g ko3n1g disabled auto-merge November 17, 2024 21:39
@ko3n1g ko3n1g merged commit 315057b into main Nov 17, 2024
7 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/chore/add-dev-semver branch November 17, 2024 21:40
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 22, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: abukharin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants