Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move semantic-pr into templates repo #408

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Nov 18, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@ko3n1g ko3n1g requested a review from terrykong November 18, 2024 09:31
@github-actions github-actions bot added the CI label Nov 18, 2024
@ko3n1g ko3n1g merged commit 5075f94 into main Nov 19, 2024
8 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/ci/move-semantic-pr-validor branch November 19, 2024 09:52
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 22, 2024
Signed-off-by: Oliver Koenig <[email protected]>
Signed-off-by: abukharin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants