Alcray/autoform refactor #317
Open
+673
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexan <[email protected]>
Signed-off-by: Alexan <[email protected]>
Signed-off-by: Alexan <[email protected]>
Signed-off-by: Alexan <[email protected]>
Signed-off-by: Alexan <[email protected]>
Signed-off-by: Alexan <[email protected]>
Signed-off-by: Alexan <[email protected]>
Kipok
reviewed
Feb 4, 2025
| else: | ||
| output_file = f"{output_dir}/generation/output.jsonl" | ||
| # Fallback to original naming scheme if output_base is not provided |
There was a problem hiding this comment.
let's just use "output" as default value and then we don't need else part?
| @@ -197,7 +211,11 @@ def generate( | |||
| "Can provide an experiment name or an experiment object if running from code.", | |||
| ), | |||
| config_dir: str = typer.Option(None, help="Can customize where we search for cluster configs"), | |||
| log_dir: str = typer.Option(None, help="Can specify a custom location for slurm logs."), | |||
| log_dir: str = typer.Option(None, help="Can specify a custom location for slurm logs. "), | |||
There was a problem hiding this comment.
Suggested change
| log_dir: str = typer.Option(None, help="Can specify a custom location for slurm logs. "), | |
| log_dir: str = typer.Option(None, help="Can specify a custom location for slurm logs."), |
| @@ -197,7 +211,11 @@ def generate( | |||
| "Can provide an experiment name or an experiment object if running from code.", | |||
| ), | |||
| config_dir: str = typer.Option(None, help="Can customize where we search for cluster configs"), | |||
| log_dir: str = typer.Option(None, help="Can specify a custom location for slurm logs."), | |||
| log_dir: str = typer.Option(None, help="Can specify a custom location for slurm logs. "), | |||
| output_base: str = typer.Option( | |||
There was a problem hiding this comment.
maybe output_prefix? or output_base_name?
There was a problem hiding this comment.
Let's add it for other generation types as well, so that it's supported in all cases
| @@ -0,0 +1,28 @@ | |||
| # Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved. | |||
There was a problem hiding this comment.
What's the difference between this and the previous one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.