Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log checkpoint saves at start and finish #12018

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lepan-google
Copy link

Log checkpoint saves at start and finish

Copy link
Contributor

github-actions bot commented Feb 2, 2025

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.lightning.pytorch.callbacks.model_checkpoint
nemo/lightning/pytorch/callbacks/model_checkpoint.py:643:0: C0301: Line too long (146/119) (line-too-long)
nemo/lightning/pytorch/callbacks/model_checkpoint.py:111:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/callbacks/model_checkpoint.py:174:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/callbacks/model_checkpoint.py:251:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/callbacks/model_checkpoint.py:258:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/callbacks/model_checkpoint.py:262:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/callbacks/model_checkpoint.py:275:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/callbacks/model_checkpoint.py:22:0: W0611: Unused import lightning.pytorch (unused-import)

-----------------------------------
Your code has been rated at 9.77/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@akoumpa
Copy link
Member

akoumpa commented Feb 2, 2025

Hi @lepan-google,

thanks for the PR, can you fix DCO and push again?

DCO instructions:


Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~2 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin lepan-nemo```

@github-actions github-actions bot added core Changes to NeMo Core NLP labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core NLP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants