-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the issue during batched inference of Sortformer diarizer #12047
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Taejin Park <[email protected]>
Signed-off-by: Taejin Park <[email protected]>
…NeMo into fix/sortformer_batch_len
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12047 +/- ##
=======================================
Coverage 30.43% 30.43%
=======================================
Files 1400 1401 +1
Lines 177498 177572 +74
Branches 27203 27213 +10
=======================================
+ Hits 54016 54041 +25
- Misses 119358 119406 +48
- Partials 4124 4125 +1 ☔ View full report in Codecov by Sentry. |
[🤖]: Hi @tango4j 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
What does this PR do ?
This PR fixes the ghost timestamps issue occurs during batched inference of Sortformer model.
Collection:
ASR
Changelog
The following files are changed:
nemo/collections/asr/data/audio_to_diar_label_lhotse.py
nemo/collections/asr/models/sortformer_diar_models.py
nemo/collections/asr/modules/sortformer_modules.py
Usage
GitHub Actions CI
Run CICD
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in NeMo ASR
Additional Information
Sortformer Train/Inference