-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance-optimized example for llama2 70b LoRA #12055
Conversation
b01cbc9
to
3b9525a
Compare
"LORA_A2A": "1", | ||
"CUDA_DEVICE_MAX_CONNECTIONS": "1", | ||
"CUBLAS_FORCE_XMMA_KERNEL_INIT": "DEVICE", | ||
"CUDNN_FRONTEND_ATTN_DP_WORKSPACE_LIMIT": "0", | ||
"NVTE_FP8_DPA_BWD": "1", | ||
"NVTE_RS_STRIDED_ATOMIC": "2", | ||
"NCCL_MIN_CTAS": "32", | ||
"NCCL_MIN_P2P_NCHANNELS": "32", | ||
"NCCL_NCHANNELS_PER_NET_PEER": "32", | ||
"NCCL_NVLS_ENABLE": "0", | ||
"TORCH_NCCL_AVOID_RECORD_STREAMS": "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add description on the env vars?
Please refer this PR.
#11991
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
…ludes te's fp8_model_init and torch no_grad, update TE overlap configs to allow atomic gemm + empty entries Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: vysarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: vysarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: vysarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: vysarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
8211fd6
to
291b2f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Valerie Sarge <[email protected]>
Signed-off-by: Valerie Sarge <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12055 +/- ##
==========================================
+ Coverage 30.42% 30.43% +0.01%
==========================================
Files 1400 1402 +2
Lines 177452 177665 +213
Branches 27196 27221 +25
==========================================
+ Hits 53990 54075 +85
- Misses 119345 119465 +120
- Partials 4117 4125 +8 ☔ View full report in Codecov by Sentry. |
What does this PR do ?
This PR adds an example script for llama2 70b LoRA tuning (tp4pp1cp1 on H100) including optimized configs used in MLPerf 4.1 submission, plus supporting changes.
Requires #11961.
Collection: llm
Changelog
scripts/llm/performance/mlperf_lora_llama2_70b.py
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information