disable moe logging to avoid deepseek hang #12168
Conversation
Signed-off-by: Alexandros Koumparoulis <[email protected]>
Signed-off-by: Alexandros Koumparoulis <[email protected]>
akoumpa
force-pushed
the
akoumparouli/disable_aggregate_moe_loss_stats
branch
from
844f157 to
172d67c
Compare
Signed-off-by: akoumpa <[email protected]>
|
[🤖]: Hi @akoumpa 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
pylint Signed-off-by: Alexandros Koumparoulis <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # for loss_name, loss_value in aggregate_moe_loss_stats(loss_scale=1.0).items(): | ||
| # self.lightning_module.log( | ||
| # loss_name, loss_value, prog_bar=True, rank_zero_only=True, batch_size=1) |
Check notice
Code scanning / CodeQL
Commented-out code Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI about 15 hours ago
To fix the problem, we should remove the commented-out code entirely. This will help maintain the clarity and readability of the code. If the code is needed for future reference, it can be documented in a separate file or re-enabled with proper context.
- Locate the commented-out code in the
training_stepmethod. - Remove the commented-out lines (lines 633-635) entirely.
- Ensure that the removal does not affect the functionality of the surrounding code.
| @@ -632,5 +632,5 @@ | ||
| # TODO(@akoumparouli): loss_scale depends on the GBS. | ||
| # for loss_name, loss_value in aggregate_moe_loss_stats(loss_scale=1.0).items(): | ||
| # self.lightning_module.log( | ||
| # loss_name, loss_value, prog_bar=True, rank_zero_only=True, batch_size=1) | ||
|
|
||
|
|
||
|
|
||
|
|
|
it's only the pylint left, but has the full CI passed |
pablo-garay
deleted the
akoumparouli/disable_aggregate_moe_loss_stats
branch
* disable moe logging to avoid deepseek hang Signed-off-by: Alexandros Koumparoulis <[email protected]> * disable moe logging to avoid deepseek hang Signed-off-by: Alexandros Koumparoulis <[email protected]> * Apply isort and black reformatting Signed-off-by: akoumpa <[email protected]> * Update megatron_strategy.py pylint Signed-off-by: Alexandros Koumparoulis <[email protected]> --------- Signed-off-by: Alexandros Koumparoulis <[email protected]> Signed-off-by: akoumpa <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]> Co-authored-by: akoumpa <[email protected]>
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information