Ckpt fixes pytorch update #12228
Merged
Ckpt fixes pytorch update #12228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Truong <[email protected]>
Signed-off-by: Charlie Truong <[email protected]>
…ault_factory Signed-off-by: Charlie Truong <[email protected]>
|
Not ready for review yet. Wanting to run the tests against some of this and will need the respective devs to take a look even if this passes. |
chtruong814
force-pushed
the
ckpt-fixes-pytorch-update
branch
2 times, most recently
from
049c5fd to
7413cfb
Compare
chtruong814
requested review from
pablo-garay,
ko3n1g and
thomasdhc
as code owners
ko3n1g
pushed a commit
that referenced
this pull request
Feb 19, 2025
* Fix checkpoint loading for ptq tests Signed-off-by: Charlie Truong <[email protected]> * Pass --ckpt_load_strictness log_all to L2_NeMo_2_SSM_Finetuning test Signed-off-by: Charlie Truong <[email protected]> * Fix tests in L2_NMT_Attention_is_All_You_Need_Finetuning by using default_factory Signed-off-by: Charlie Truong <[email protected]> --------- Signed-off-by: Charlie Truong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes additional tests for the pytorch container 25.01 bump.
The PTQ and SSM finetuning tests were failing because we had to set the
ckpt_load_strictnesstolog_allsimilar to what we've done in several cases already. The NMT test was failing because the data class was not using the default factory for a mutable field, which is required for the python update to 3.12.This is merging into @ko3n1g 's Pytorch bump branch.
Collection: [Note which collection this PR will affect]
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information