[PyTorch] Rename and clean up MXFP8 recipe class #1445
Draft
+68
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1442 changed
BlockScaling
toMXFP8BlockScaling
, a big improvement since a certain other 1x128 block scaling recipe has been in the news. That said, it is still a redundant name since MXFP8 will never not use block scaling. This PR changes the name toMXFP8Recipe
and makes several other non-functional quality-of-life improvements.Type of change
Changes
MXFP8BlockScaling
toMXFP8Recipe
andMXFP8BlockScalingRecipeState
toMXFP8RecipeState
is_delayed_scaling
andis_mxfp8
to make it more obvious they are booleanis_delayed_scaling
andis_mxfp8
class variables instead of functionsis_delayed_scaling
instead ofis_mxfp8
when dealing with delayed scaling logicChecklist: