Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoE][PyTorch] Add prob permutation to mask-based MoE permutation; Fix FP8 related codes #1468

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hxbai
Copy link
Contributor

@hxbai hxbai commented Feb 9, 2025

Description

Add probs permutation codes to the mask-based permutation. With this, we can apply the probs to the MoE expert MLP rather than to the unpermutation to avoid saving huge input tensor of unpermute function.

Fix FP8 Tensor usages in the permutation codes since TE 2.0 has some breaking changes on FP8 Tensor interfaces.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Add probs permutation to the functions of moe_permute and moe_sort_chunks_by_index
  • Fix FP8 related codes

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant