-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MOE tests #1476
Fix MOE tests #1476
Conversation
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
transformer_engine/pytorch/tensor/_internal/float8_tensor_base.py
Outdated
Show resolved
Hide resolved
@@ -308,6 +308,18 @@ def reshape(self, *shape: Tuple[int]) -> Float8Tensor: | |||
# pylint: disable=missing-function-docstring | |||
return _ReshapeFunc.apply(self, shape) | |||
|
|||
@classmethod | |||
def to_float8( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer naming this quantize
so that we can generalize to the other quantized tensor classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant as a standalone quantization for a high precision tensor and I think it would be better for this to not conflict with existing quantize function in QuantizedTensor
.
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait wait wait. Why are we adding the to_float8 function again? We should just fix the tests to create and use the quantizer instead.
I think the |
Description
The code drop for 2.0 results in breaking certain tests in the CI. This PR fixes the MOE/permutation tests.
Type of change
Checklist: