Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for 2.0 release #1479

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Update documentation for 2.0 release #1479

merged 7 commits into from
Feb 12, 2025

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Feb 12, 2025

Description

Updated documentation for 2.0 release. Added MXFP8 section.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ptrendx ptrendx requested a review from timmoon10 February 12, 2025 00:38
@ptrendx
Made the figures larger
7130875 
Signed-off-by: Przemek Tredak <[email protected]>
timmoon10
timmoon10 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just minor suggestions for clarity, precision, and flow.

ptrendx and others added 3 commits February 11, 2025 22:51
ksivaman
ksivaman approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

@ptrendx @ksivaman
Change from review
06217cd 
Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Przemyslaw Tredak <[email protected]>
@ptrendx ptrendx merged commit ee4a17d into NVIDIA:main Feb 12, 2025
11 checks passed
ptrendx added a commit that referenced this pull request Feb 12, 2025
@ptrendx @timmoon10
@pre-commit-ci @ksivaman
Update documentation for 2.0 release (#1479)
e5cc6c2 
* Updated docs for TE 2.0

Signed-off-by: Przemek Tredak <[email protected]>

* Do not expose comm_gemm_overlap and cast_transpose_noop

Signed-off-by: Przemek Tredak <[email protected]>

* Made the figures larger

Signed-off-by: Przemek Tredak <[email protected]>

* Apply suggestions from code review

Co-authored-by: Tim Moon <[email protected]>
Signed-off-by: Przemyslaw Tredak <[email protected]>

* Update quickstart_utils.py

Signed-off-by: Przemek Tredak <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change from review

Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Przemyslaw Tredak <[email protected]>

---------

Signed-off-by: Przemek Tredak <[email protected]>
Signed-off-by: Przemyslaw Tredak <[email protected]>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
phu0ngng pushed a commit to phu0ngng/TransformerEngine that referenced this pull request Feb 13, 2025
@ptrendx @timmoon10
@pre-commit-ci @ksivaman @phu0ngng
Update documentation for 2.0 release (NVIDIA#1479)
8e4de2b 
* Updated docs for TE 2.0

Signed-off-by: Przemek Tredak <[email protected]>

* Do not expose comm_gemm_overlap and cast_transpose_noop

Signed-off-by: Przemek Tredak <[email protected]>

* Made the figures larger

Signed-off-by: Przemek Tredak <[email protected]>

* Apply suggestions from code review

Co-authored-by: Tim Moon <[email protected]>
Signed-off-by: Przemyslaw Tredak <[email protected]>

* Update quickstart_utils.py

Signed-off-by: Przemek Tredak <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change from review

Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Signed-off-by: Przemyslaw Tredak <[email protected]>

---------

Signed-off-by: Przemek Tredak <[email protected]>
Signed-off-by: Przemyslaw Tredak <[email protected]>
Co-authored-by: Tim Moon <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmoon10 timmoon10 timmoon10 approved these changes

@ksivaman ksivaman ksivaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptrendx @timmoon10 @ksivaman