Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlisted distributions #62

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Unlisted distributions #62

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdcff04
Include Ubuntu24.04 in list of supported platforms
elezar May 17, 2024
135764f
Add note on newer distributions
elezar May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion container-toolkit/supported-platforms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,12 @@ backlinks: none

## Linux Distributions

Supported Linux distributions are listed below:
The NVIDIA Container Toolkit has been qualified against the following platforms.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect your choice of "qualified" rather than supported is to communicate some subtlety. If feels dicey to me, but it's you who answers questions and not me.

nit: s/has been/is/, unless there is a consideration that I'm overlooking.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that people reach out to us all the time pointing out that we need to add "Debian 12" support or "Ubuntu 24.04" support, where we are reasonably confident that the packages should work as is. The caveat is that we have not officiallty tested against these configurations. If you have a suggestion on how to better call this out, that would be appreciated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example: NVIDIA/nvidia-container-toolkit#482 (comment)


Note that the installation packages are generally forward-compatible and the
omission of newer distributions from this list below does not indicate that the
NVIDIA Container Toolkit cannot be used there. Specific issues with newer
distributions should be reported.
Comment on lines +21 to +24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be rephrased more concisely.

NVIDIA Container Toolkit is generally forward compatible and works successfully on newer versions of the operating systems in the following table.

I've puzzled through the thought of directing readers to report issues from this section of the text, and I can't think why it's more compelling to urge that action here than in any other section. If you prefer to keep it, consider something like "Open an issue in the toolkit repository to report problems."


| OS Name / Version | amd64 / x86_64 | ppc64le | arm64 / aarch64 |
| ------------------------ | -------------- | ------- | --------------- |
Expand Down