-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUDA-Q quantum transformer tutorial #2614
base: main
Are you sure you want to change the base?
CUDA-Q quantum transformer tutorial #2614
Conversation
@anthonysmaldone Thanks for putting up this PR. Would you please run the following commands to fix the CI build failures?
|
Command Bot: Processing... |
When I run to run the notebook in local dev container, I see the following error
|
@sacpis I have fixed the installation issue and restyled the code. There are basic machine learning and chemistry terms that fail during spellcheck (such as 'logits', 'dataset', 'stereocenters', 'physicochemical', etc) should I add some of these to the spelling_allowlist.txt in the workflow config? |
@anthonysmaldone You can wrap those in ``. I think those are in the comments, right? |
@sacpis Yes, they should all be in comments/docstrings |
@sacpis I have made the requested changes, please let me know if there is anything else I can do. |
Command Bot: Processing... |
@anthonysmaldone We are getting the following doc error https://github.com/NVIDIA/cuda-quantum/actions/runs/13570884770/job/37937243190?pr=2614#step:9:276 Would you please include the python notebook in docs/sphinx/using/applications.rst file? |
@sacpis I've added the notebook to the application.rst file |
Command Bot: Processing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @anthonysmaldone.
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
@bmhowe23 Is it safe to skip the conversion of quantum_transformer notebook? It is taking long and failing. |
That should probably be answered by @bettinaheim. We normally like to be able to test our published examples on a regular basis to ensure they don't break with any new cuda-quantum code updates. Skipping testing of this notebook would expose us to the risk of it breaking and us not knowing about it. Are you proposing skipping testing of this in just the per-PR CI (CPU only), all CI (even tests w/ GPUs), or all automated testing (even release-level QA testing)? |
Thank you @bmhowe23.
I am proposing to skip this in just the per-PR CI (CPU only). |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
@sacpis After checking the docs preview, I noticed the sections of the transformer notebook are headings under "Applications", let if know if I should change the notebook |
@anthonysmaldone Sure. Would you please tell me where should it go? |
@sacpis It should still be under 'Applications". However now I see that Applications has subheadings "Installation", "Algorithm and Examples" and "Usage" -which are the section titles in the notebook. Do they need to be one level smaller in the tutorial notebook? |
Ah, I see what you are referring to. Please use |
Head branch was pushed to by a user without write access
@sacpis Sounds good, ive made the updates |
Description
This is a
ipynb
notebook and corresponding scripts that include a tutorial of a hybrid quantum-classical transformer model from the paper: A Hybrid Transformer Architecture with a Quantized Self-Attention Mechanism Applied to Molecular Generation - a collaborative effort between NVIDIA and Yale University.