Fixes for NoiseModel when using with fp32 targets
#2672
Merged
+46
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thien Nguyen <[email protected]>
1tnguyen
force-pushed
the
tnguyen/apply-noise-fix
branch
from
f9f6d57 to
6f41b89
Compare
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
approved these changes
Feb 28, 2025
bmhowe23
approved these changes
Feb 28, 2025
Actually, it was the 'enhanced' In the latest |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
parameterswas defined as avector<double>; hence we need to cast ifcudaq::realisfloat.get_channelusingparamstype to deduct the variant type is not reliable; could lead to bad variant access. Hence, perform aholds_alternativecheck before callingstd::get. If needed, perform a type casting to retrieve the correct variant type.