add additional type_traits methods #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbarsdell
requested changes
May 12, 2020
| @@ -1709,6 +1709,20 @@ static const char* jitsafe_header_type_traits = R"( | |||
| template<class Ret, class... Args> struct is_function<Ret(Args...)> : true_type {}; //regular | |||
| template<class Ret, class... Args> struct is_function<Ret(Args......)> : true_type {}; // variadic | |||
|
|
|||
| template<typename T> struct make_signed { typedef T type; }; | |||
| template<> struct make_signed<unsigned char> { typedef signed char type; }; | |||
There was a problem hiding this comment.
Need a separate specialization for char (which is a distinct type and not necessarily signed or unsigned).
| template<> struct make_signed<unsigned long long> { typedef signed long long type; }; | ||
|
|
||
| template<typename T> struct make_unsigned { typedef T type; }; | ||
| template<> struct make_unsigned<char> { typedef unsigned char type; }; |
There was a problem hiding this comment.
Need a separate specialization for signed char.
| template<> struct make_signed<unsigned int> { typedef signed int type; }; | ||
| template<> struct make_signed<unsigned long> { typedef signed long type; }; | ||
| template<> struct make_signed<unsigned long long> { typedef signed long long type; }; | ||
|
|
There was a problem hiding this comment.
Also need specializations to preserve CV-qualifiers.
Suggested change
| template<typename T> struct make_signed<const T> { typedef const typename make_signed<T>::type type; }; | |
| template<typename T> struct make_signed<volatile T> { typedef volatile typename make_signed<T>::type type; }; | |
| template<typename T> struct make_signed<const volatile T> { typedef const volatile typename make_signed<T>::type type; }; | |
| template<> struct make_unsigned<int> { typedef unsigned int type; }; | ||
| template<> struct make_unsigned<long> { typedef unsigned long type; }; | ||
| template<> struct make_unsigned<long long> { typedef unsigned long long type; }; | ||
|
|
There was a problem hiding this comment.
Also need specializations to preserve CV-qualifiers.
Suggested change
| template<typename T> struct make_unsigned<const T> { typedef const typename make_unsigned<T>::type type; }; | |
| template<typename T> struct make_unsigned<volatile T> { typedef volatile typename make_unsigned<T>::type type; }; | |
| template<typename T> struct make_unsigned<const volatile T> { typedef const volatile typename make_unsigned<T>::type type; }; | |
| @@ -1709,6 +1709,20 @@ static const char* jitsafe_header_type_traits = R"( | |||
| template<class Ret, class... Args> struct is_function<Ret(Args...)> : true_type {}; //regular | |||
| template<class Ret, class... Args> struct is_function<Ret(Args......)> : true_type {}; // variadic | |||
|
|
|||
| template<typename T> struct make_signed { typedef T type; }; | |||
There was a problem hiding this comment.
Can you add a specialization for bool with no implementation.
| template<> struct make_signed<unsigned long> { typedef signed long type; }; | ||
| template<> struct make_signed<unsigned long long> { typedef signed long long type; }; | ||
|
|
||
| template<typename T> struct make_unsigned { typedef T type; }; |
There was a problem hiding this comment.
Can you add a specialization for bool with no implementation.
| @@ -1709,6 +1709,20 @@ static const char* jitsafe_header_type_traits = R"( | |||
| template<class Ret, class... Args> struct is_function<Ret(Args...)> : true_type {}; //regular | |||
| template<class Ret, class... Args> struct is_function<Ret(Args......)> : true_type {}; // variadic | |||
|
|
|||
| template<typename T> struct make_signed { typedef T type; }; | |||
There was a problem hiding this comment.
Also can you add a TODO noting that there are more complicated rules for enums, char, wchar_t etc. that aren't implemented here.
|
@jglaser just wondering if you'll get round to making the requested changes for this nice PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable compilation of code which includes the Random123 RNG library, we need the
std::make_signed<>templates, which I am adding in this PR.