Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a centralized controller to advertise IMEX channel #178

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

klueska
Copy link
Collaborator

@klueska klueska commented Oct 11, 2024

This component is responsible for publishing ResourceSlices which advertise IMEX channels for each discovered IMEX domain in a cluster.

Copy link

@guptaNswati guptaNswati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. not sure, if we need a timeout condition to handle any lags in the creation and deletion of the new and old imex channels. I do see the 10 min time sync.

@klueska
Copy link
Collaborator Author

klueska commented Oct 12, 2024

The first node that pops up that is part of a unique IMEX domain, immediately triggers the creation of a ResourceSlice with IMEX channels for that domain. The last node that is part of a unique IMEX domain to disappear, immediately triggers the deletion of the ResourceSlice with IMEX channels for that domain.

The 10min time-sync is how often the informer forces a manual sync of its cache. Under normal operation every add/update/delete triggers an update of this cache, but this timed-sync ensures that it is also done periodically in the absence of these events (and to avoid potential races / bugs, of which there are no known ones).

@klueska klueska force-pushed the add-imex-controller branch 2 times, most recently from a321e5c to 37b369f Compare October 12, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants