Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pymilvus version in client/requirement.txt #422

Closed

Conversation

shan-nvidia
Copy link

@shan-nvidia shan-nvidia commented Feb 10, 2025

Description

This is to fix the pymilvus version in client/requirement.txt. Currently the client failed with error

(nv-ingest) (base) sthan@ipp1-3302:/raid/sthan/nv-ingest/client$ nv-ingest-cli --version
Traceback (most recent call last):
  File "/raid/sthan/miniforge3/envs/nv-ingest/bin/nv-ingest-cli", line 5, in <module>
    from nv_ingest_client.nv_ingest_cli import main
  File "/raid/sthan/miniforge3/envs/nv-ingest/lib/python3.10/site-packages/nv_ingest_client/nv_ingest_cli.py", line 15, in <module>
    from nv_ingest_client.cli.util.click import LogLevel
  File "/raid/sthan/miniforge3/envs/nv-ingest/lib/python3.10/site-packages/nv_ingest_client/cli/util/click.py", line 14, in <module>
    from nv_ingest_client.cli.util.processing import check_schema
  File "/raid/sthan/miniforge3/envs/nv-ingest/lib/python3.10/site-packages/nv_ingest_client/cli/util/processing.py", line 24, in <module>
    from nv_ingest_client.client import NvIngestClient
  File "/raid/sthan/miniforge3/envs/nv-ingest/lib/python3.10/site-packages/nv_ingest_client/client/__init__.py", line 6, in <module>
    from nv_ingest_client.client.interface import Ingestor
  File "/raid/sthan/miniforge3/envs/nv-ingest/lib/python3.10/site-packages/nv_ingest_client/client/interface.py", line 31, in <module>
    from nv_ingest_client.util.milvus import MilvusOperator
  File "/raid/sthan/miniforge3/envs/nv-ingest/lib/python3.10/site-packages/nv_ingest_client/util/milvus.py", line 1, in <module>
    from pymilvus import (
ImportError: cannot import name 'Function' from 'pymilvus' (/raid/sthan/miniforge3/envs/nv-ingest/lib/python3.10/site-packages/pymilvus/__init__.py)

Updated it to the same version as specified in ./conda/environments/nv_ingest_environment.yml

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Feb 10, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shan-nvidia
Copy link
Author

Close this MR since it's already included in #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant