Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UCX 1.16.0 upgrade #10190

Merged
merged 9 commits into from
Jan 26, 2024
Merged

UCX 1.16.0 upgrade #10190

merged 9 commits into from
Jan 26, 2024

Conversation

abellina
Copy link
Collaborator

@abellina abellina commented Jan 11, 2024

I'd like for us to merge and get this through CI. Technically, this is using UCX 1.16 at an RC level, which really impacts the jucx JAR. This was done to pick up an arm version of libucx. I have updated dockerfiles to install UCX 1.16-rc1 native bits, and as UCX releases this fully we will be able to remove the "rc" part of it.

Closes #7116.

Related UCX issue openucx/ucx#9523.

@abellina
Copy link
Collaborator Author

build

@abellina
Copy link
Collaborator Author

build

@abellina
Copy link
Collaborator Author

build

@sameerz sameerz added the feature request New feature or request label Jan 11, 2024
@abellina
Copy link
Collaborator Author

build

1 similar comment
@abellina
Copy link
Collaborator Author

build

@abellina
Copy link
Collaborator Author

build

@abellina abellina changed the title UCX 1.16.0 upgrade WIP UCX 1.16.0 upgrade Jan 24, 2024
@abellina abellina marked this pull request as ready for review January 24, 2024 17:18
@abellina
Copy link
Collaborator Author

build

jenkins/Dockerfile-blossom.multi Outdated Show resolved Hide resolved
jenkins/Dockerfile-blossom.ubuntu Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits, but I am not happy with pulling in an release candidate for UCX. Is there a timeline for when it will be fully released?

@@ -33,11 +33,11 @@ ARG UCX_VER
ARG UCX_CUDA_VER
ARG UCX_ARCH

RUN yum update -y && yum install -y wget bzip2 numactl-libs libgomp
# note that libibmad is a temporary workaround for a missed dependency in ucx-1.16 rpm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue to fix this? Or to move to a non-rc version of UCX?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be included in the next RC for UCX. The UCX team is working on it here: openucx/ucx#9628.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small precision, libibmad/libibumad dep as just been removed by openucx/ucx#9625 and openucx/ucx#9627. other PRs are longer term effort.

RUN ls /usr/lib
RUN mkdir /tmp/ucx_install && cd /tmp/ucx_install && \
wget https://github.com/openucx/ucx/releases/download/v$UCX_VER/ucx-$UCX_VER-centos8-mofed5-cuda$UCX_CUDA_VER-$UCX_ARCH.tar.bz2 && \
tar -xvf *.bz2 && \
rpm -i ucx-$UCX_VER*.rpm && \
rpm -i ucx-cuda-$UCX_VER*.rpm --nodeps && \
rpm -i `ls ucx-[0-9]*.rpm ucx-cuda-[0-9]*.rpm` --nodeps && \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the rpm is not named consistently with the version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct :( It is an RC issue as well, when you drop the RC it works. That said, I figured this was a bit more robust, because we have nothing else in this directory /tmp/ucx_install, so it's only UCX at this rate.

Copy link
Contributor

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me other than resolving the "should we depend on a release candidate now rather than wait" issue.

@sameerz
Copy link
Collaborator

sameerz commented Jan 25, 2024

I understand this is a release candidate for UCX. I am ok using it since we are doing most of the testing on UCX 1.16-rc for our use case.

@abellina
Copy link
Collaborator Author

build

Copy link
Collaborator

@NvTimLiu NvTimLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@abellina abellina merged commit 8ab25cd into NVIDIA:branch-24.02 Jan 26, 2024
40 checks passed
@abellina abellina deleted the ucx_1.16_wip branch January 26, 2024 16:15
abellina added a commit to abellina/spark-rapids that referenced this pull request Jan 26, 2024
This reverts commit 8ab25cd.

Signed-off-by: Alessandro Bellina <[email protected]>
abellina added a commit to abellina/spark-rapids that referenced this pull request Jan 26, 2024
This reverts commit 8ab25cd.

Signed-off-by: Alessandro Bellina <[email protected]>
andygrove pushed a commit that referenced this pull request Jan 26, 2024
This reverts commit 8ab25cd.

Signed-off-by: Alessandro Bellina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] support cpu-architecture based jucx dependency
6 participants