Fix the flaky test in ThrottlingExecutorSuite #12094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test task metrics
test is flaky. This test verifies the max throttle time metric in theThrottlingExecutor
while there are two tasks in the executor, one running and another waiting. The way it measures the expected max of the max throttle time is not quite right. Here is a brief summary of what this test does:The last verification can flake because the sleep time may not reflect the actual wait time in the
ThrottlingExecutor
. Submitting a task can take some time which will reduce the actual wait time in the executor. This PR fixes this test by using the actual wait time to validate the metric.