Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert ucx 1.18 upgrade #12105

Merged
merged 2 commits into from
Feb 12, 2025
Merged

revert ucx 1.18 upgrade #12105

merged 2 commits into from
Feb 12, 2025

Conversation

zpuller
Copy link
Collaborator

@zpuller zpuller commented Feb 11, 2025

Reverts #12058

The above PR was found to break ucx_perftest with -m cuda in the ubuntu rdma container in a CI test. This is caused specifically by the CUDA version upgrade in the PR.

Signed-off-by: Zach Puller <[email protected]>
@zpuller zpuller requested a review from a team as a code owner February 11, 2025 18:32
abellina
abellina previously approved these changes Feb 11, 2025
@abellina
Copy link
Collaborator

build

razajafri
razajafri previously approved these changes Feb 11, 2025
@razajafri
Copy link
Collaborator

razajafri commented Feb 11, 2025

Just to understand, can you answer why we were upgrading the CUDA version? What impact will it have by reverting?

@zpuller
Copy link
Collaborator Author

zpuller commented Feb 11, 2025

Just to understand, can you answer why we were upgrading the CUDA version? What impact will it have by reverting?

The new version supports fabric memory handles and have support for grace-blackwell, which will be supported in UCX 1.18.1. But there won't be any impact to reverting.

Signed-off-by: Zach Puller <[email protected]>
@zpuller zpuller dismissed stale reviews from razajafri and abellina via 984b274 February 11, 2025 21:41
@zpuller
Copy link
Collaborator Author

zpuller commented Feb 11, 2025

build

@zpuller zpuller merged commit 9db0338 into NVIDIA:branch-25.04 Feb 12, 2025
51 checks passed
@zpuller zpuller changed the title revert ucx upgrade revert ucx 1.18 upgrade Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants