set concurrent tasks on batch size and GPU memory #12140
+28
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert (Bobby) Evans <[email protected]>
|
I should add that I have not run any performance tests yet. We need to do that before checking this in. |
|
build |
gerashegalov
approved these changes
Feb 15, 2025
winningsix
reviewed
Feb 17, 2025
| val batchBytes = Option(batchStr) | ||
| .map(ConfHelper.byteFromString(_, ByteUnit.BYTE)) | ||
| .getOrElse(RapidsConf.GPU_BATCH_SIZE_BYTES.defaultValue) | ||
| math.max(1, math.min(4, memory / (4 * batchBytes))).toInt |
There was a problem hiding this comment.
Should we keep consistent with auto-tooler (4 -> 8) or just remove the suggestions logic there since it's calculated by batch size and GPU memory already?
In auto-tooler, it uses gpuMemPerTaskMB (used 7500 MB. ~7.5GB per task) and total memory to calculate the concurrent GPU task config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9160
but we probably need a follow on issue to disable the auto tuner from setting concurrent GPU tasks.
The new default for concurentGPUTasks is
GPU memory / (target batch size * 4)with a minimum of 1 task and a maximum of 4 tasks. We may adjust the maximum if we get better results for larger GPUs.