Fixed dimension of frequency threshold in 2d #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the paper's Figure 3: https://openreview.net/pdf?id=EXHG-A3jlM
I think the number of modes threshold in 2d
AFNO-transformer/afno/afno2d.py
Lines 54 to 55 in 941e924
should be
W
instead ofN
sinceN = H*W
, similar applies tobfno2d.py
.Nice paper btw. @jtguibas