Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dimension of frequency threshold in 2d #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scaomath
Copy link

@scaomath scaomath commented Nov 7, 2022

Based on the paper's Figure 3: https://openreview.net/pdf?id=EXHG-A3jlM

I think the number of modes threshold in 2d

total_modes = N // 2 + 1
kept_modes = int(total_modes * self.hard_thresholding_fraction)

should be W instead of N since N = H*W, similar applies to bfno2d.py.

Nice paper btw. @jtguibas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant