Coupling approval with school #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
February 6, 2025 23:28
…ldfront into coupling_approval_with_school
…eview_allocation_requests to AllocationChangeDetailView, add AllocationRequestListViewTest and AllocationChangeDeleteAttributeViewTest
… allocation request review + added tests for load_approver_schools.py
…attributes. Provide AllocationDetailView access to approvers but restricted based on their associated schools. Enable POST requests on AllocationDetailView for approvers. Added test cases to verify school-based access control for approvers.
…f, 'approver_profile') in UserProfile
dahyehayley
commented
Feb 24, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM python:3.8 | |||
There was a problem hiding this comment.
Let me rollback this change - this was for my local development
…locationChangeDetailViewTest. Moved restriction to test_func level in AllocationChangeDeleteAttributeView
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support restricting allocation review (AllocationRequestListView, AllocationChangeListView, AllocationChangeDeleteAttributeView) to approvers and their schools.