feat: correct migrations for user sessions columns

core/classes/Core/User.php

@@ -305,7 +305,6 @@ private function _commonLogin(?string $username, ?string $password, bool $rememb
             }
         } elseif ($this->checkCredentials($username, $password, $method) === true) {
             // Valid credentials
-            // TODO: job to remove old sessions?
             $hash = SecureRandom::alphanumeric();
             $expiresAt = $remember ? time() + Config::get('remember.cookie_expiry') : null;
 

core/migrations/20220807142446_add_user_session_activity_columns.php

@@ -11,7 +11,7 @@ public function change(): void
         $table = $this->table('nl2_users_session');
         $table->addColumn('remember_me', 'boolean', ['default' => false]);
         $table->addColumn('active', 'boolean', ['default' => false]);
-        $table->addColumn('user_agent', 'string', ['length' => 256, 'null' => true, 'default' => null]);
+        $table->addColumn('device_name', 'string', ['length' => 256, 'null' => true, 'default' => null]);
         $table->addColumn('last_seen', 'integer', ['length' => 11, 'null' => true, 'default' => null]);
         $table->addColumn('login_method', 'string', ['length' => 32]);
         $table->addIndex('hash', ['unique' => true]);

core/migrations/20240714105154_rename_device_name_column_users_session_table.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+use Phinx\Migration\AbstractMigration;
+
+final class RenameDeviceNameColumnUsersSessionTable extends AbstractMigration
+{
+    public function up(): void
+    {
+        $table = $this->table('nl2_users_session');
+        $table->renameColumn('device_name', 'user_agent')->save();
+    }
+
+    public function down(): void
+    {
+        $table = $this->table('nl2_users_session');
+        $table->renameColumn('user_agent', 'device_name')->save();
+    }
+}