feat: template base should not be nullable in onPageLoad

NamelessMC · Dec 10, 2024 · f0d1b08 · f0d1b08
1 parent 0ef096e
commit f0d1b08
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/core/classes/Core/Module.php b/core/classes/Core/Module.php
@@ -79,9 +79,9 @@ public static function getModules(): iterable
      * @param FakeSmarty|Smarty $smarty   Instance of smarty to pass, to be removed in 2.3.0
      * @param Navigation[]      $navs     Array of loaded navigation menus.
      * @param Widgets           $widgets  Instance of widget class to pass.
-     * @param TemplateBase|null $template Active template to render.
+     * @param TemplateBase      $template Active template to render.
      */
-    abstract public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, iterable $navs, Widgets $widgets, ?TemplateBase $template);
+    abstract public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, iterable $navs, Widgets $widgets, TemplateBase $template);
 
     /**
      * Determine loading arrangement of modules.

diff --git a/modules/Cookie Consent/module.php b/modules/Cookie Consent/module.php
@@ -50,7 +50,7 @@ public function onDisable() {
         // Not necessary for CookieConsent
     }
 
-    public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, $navs, Widgets $widgets, ?TemplateBase $template) {
+    public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, $navs, Widgets $widgets, TemplateBase $template) {
         $language = $this->_language;
 
         // AdminCP

diff --git a/modules/Core/module.php b/modules/Core/module.php
@@ -606,7 +606,7 @@ public function onPageLoad(
         $smarty,
         iterable $navs,
         Widgets $widgets,
-        ?TemplateBase $template
+        TemplateBase $template
     ) {
         $language = $this->_language;
 

diff --git a/modules/Discord Integration/module.php b/modules/Discord Integration/module.php
@@ -57,7 +57,7 @@ public function onDisable() {
     public function onEnable() {
     }
 
-    public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, $navs, Widgets $widgets, ?TemplateBase $template) {
+    public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, $navs, Widgets $widgets, TemplateBase $template) {
         PermissionHandler::registerPermissions($this->getName(), [
             'admincp.discord' => $this->_language->get('admin', 'integrations') . ' &raquo; ' . Discord::getLanguageTerm('discord'),
         ]);

diff --git a/modules/Forum/module.php b/modules/Forum/module.php
@@ -192,7 +192,7 @@ public function onPageLoad(
         $smarty,
         iterable $navs,
         Widgets $widgets,
-        ?TemplateBase $template
+        TemplateBase $template
     ) {
         // AdminCP
         PermissionHandler::registerPermissions('Forum', [

diff --git a/modules/Members/module.php b/modules/Members/module.php
@@ -46,7 +46,7 @@ public function onDisable() {
         // Not necessary for CookieConsent
     }
 
-    public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, $navs, Widgets $widgets, ?TemplateBase $template) {
+    public function onPageLoad(User $user, Pages $pages, Cache $cache, $smarty, $navs, Widgets $widgets, TemplateBase $template) {
         $language = $this->_language;
 
         // AdminCP