Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode oauth scopes #3536

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Don't hardcode oauth scopes #3536

wants to merge 1 commit into from

Conversation

partydragen
Copy link
Member

Don't hardcode oauth scopes, Such as email is forced for all but integrations such as twitch does not have that scope name when trying to auth it returns invalid scope

  • ability to add several scopes

@partydragen partydragen added this to the 2.2.0 milestone Aug 18, 2024
Copy link
Member

@tadhgboyle tadhgboyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An array merge here might be better instead of making the provider manually add back the email and ID scope

@partydragen
Copy link
Member Author

An array merge here might be better instead of making the provider manually add back the email and ID scope

We can't merge as some providers don't have the email scope, that causes the it to return invalid scope error on their end

Also when scopes is null, the league library will use the providers default scopes (Not currently will current backwards compability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants