-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brightcrowd Integration #2783
base: master
Are you sure you want to change the base?
Brightcrowd Integration #2783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. It would be great to share the documentation if you have some so we can double check the values there
@@ -0,0 +1,65 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can follow other documentation models that would be great. No need to fill information if you are not sure
brightcrowd: | ||
display_name: BrightCrowd | ||
categories: | ||
- alumni-data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- alumni-data | |
- social |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add it to social.mdx please
token_request_auth_method: basic | ||
token_params: | ||
grant_type: client_credentials | ||
scope: bcb.partner/book.read |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it's correct, you have to request this scope in your own integration no?
categories: | ||
- alumni-data | ||
auth_mode: BASIC | ||
token_url: https://bcb-staging.auth.us-east-1.amazoncognito.com/oauth2/token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is staging correct?
they don't advertise any API on their website, not confident about this URL
@travistatro , just to add on what @bodinsamuel has mentioned, according to the provider's documentation, the authentication mode should be |
Probably this would work but will have to confirm by creating a new connection on Nango and also try on the pagination especially
|
Thank you for the feedback/responses. I am sharing this with an engineer on my team to help move some of this forward! |
@travistatro , I have opened a new PR in reference to this. Could you be having test credentials to test the implementation? |
## Describe your changes - Add support for brightcrowd - Follow up to [2783](#2783) - Placing this in draft to see if we can get it tested. ## Issue ticket number and link [EXT-222](https://linear.app/nango/issue/EXT-222/clean-up-pr-to-get-it-pushed-to-the-platform)
Describe your changes
Checklist before requesting a review (skip if just adding/editing APIs & templates)
[-] I added tests, otherwise the reason is: This PR is only adding documentation for a new API integration
[-] I added observability, otherwise the reason is: Not applicable for API documentation
[-] I added analytics, otherwise the reason is: Not necessary for adding a new API integration documentation
The main changes are in the following file: