Add support for tinySA Ultra+ ZS-407, ZS-406, ZS-405 and tinySA and fix crashing due to operations on Integer #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, 11, 51, 201, 301, 501, 801
…t uppercase SN commands or lowercase sn commands
…feature in new Class NanoVNA_F_V3 rather than modifying the VNA.py
…rsion and hardware revision can be shown in app, screen-capture is alive and fix crashing caused by operations on Integer
…rsion and hardware revision can be shown in app, screen-capture is alive and fix crashing caused by operations on Integer
zarath
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hardware_revisionin classTinySA_Ultrafor future need which would be displayed in the Device settings -> StatusThis is an onward pull-request after my another pull-request for adding support for NanoVNA-F V3 from here: #751
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Crashing due to bad operations on Integer when testing with a tinySA Ultra+ ZS-407
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
Sometimes it's very useful to capture screenshot of tinySA (Ultra or Ultra+) with nanovna-saver app on macOS because the outdated tinysa-app delivered by someone only work on Windows