Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/settings #778

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Fix/settings #778

merged 5 commits into from
Feb 1, 2025

Conversation

redrathnure
Copy link
Contributor

Fix application settings saving and restoring.

It fixes #777 and was mentioned in #768

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • [] Feature
  • [] Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • [] Build-related changes
  • [] Documentation content changes
  • [] Other (please describe):

What is the current behavior?

  • some of settings (e.g. font size) are not restored between run sessions
  • sweep configuration is not saved between run sessions
  • app crashes right before exit

Issue Number: 777

What is the new behavior?

settings are saved on exit and restored on app start

Does this introduce a breaking change?

  • [] Yes
  • No

Other information

@redrathnure redrathnure requested a review from zarath as a code owner January 29, 2025 22:48
Copy link
Collaborator

@zarath zarath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks1

@zarath zarath merged commit e9a85b6 into NanoVNA-Saver:main Feb 1, 2025
2 checks passed
@redrathnure redrathnure mentioned this pull request Feb 1, 2025
2 tasks
@redrathnure redrathnure deleted the fix/settings branch February 16, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Saving last setting in new NanoVNA-Saver.
2 participants