Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #425

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix typos #425

merged 2 commits into from
Oct 13, 2024

Conversation

FarukhS52
Copy link
Contributor

@FarukhS52 FarukhS52 commented Oct 10, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@aaronchantrill aaronchantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking a look at this project and offering a pull request. All of these are technically correct. There are two small issues I have. "Labelling" (two L's) is the UK spelling, while "labeling" is correct for US English. The general rule regarding US vs UK English is to be consistent, so whether this is correct or not depends on the rest of the grammar on the page. The other is that both "Thank you to all the people who already contributed" and "Thank you to all the people who have already contributed" are also both technically correct - the second version is just longer. That being said, I'm going to go ahead and approve this since your other corrections are clearly correct and these are technically correct, so will improve the documents. Thank you.

@aaronchantrill aaronchantrill merged commit 1b9e581 into NaomiProject:naomi-dev Oct 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants