fix: ext_name is used in the directory structure #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service name is taken from the file e.g. event_store.service so if ext_name has hyphens these won't match up and we'll get errors like LifecycleEvent - AfterInstall Script - bin/deploy-extract-release [stdout]==> Removing previous release /srv/event-store/current [stdout]==> Extracting release from tar file /opt/codedeploy-agent/deployment-root/5b9577ac-428f-4dbf-82ce-79d9fe70d88a/d-7N1LS0I86/deployment-archive/bin/../event_store.tar.gz Script - bin/deploy-set-perms Script - bin/deploy-enable [stdout]==> Enabling systemd unit event_store [stderr]Failed to enable unit: Unit file event_store.service does not exist.
puzza007
force-pushed
the
fix/align-ext-name-and-service-name
branch
from
732a8ce to
4f50661
Compare
narrative-donc
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service name is taken from the file e.g. event_store.service so if ext_name has hyphens these won't match up and we'll get errors like
LifecycleEvent - AfterInstall
Script - bin/deploy-extract-release
[stdout]==> Removing previous release /srv/event-store/current [stdout]==> Extracting release from tar file /opt/codedeploy-agent/deployment-root/5b9577ac-428f-4dbf-82ce-79d9fe70d88a/d-7N1LS0I86/deployment-archive/bin/../event_store.tar.gz Script - bin/deploy-set-perms
Script - bin/deploy-enable
[stdout]==> Enabling systemd unit event_store
[stderr]Failed to enable unit: Unit file event_store.service does not exist.