[FINNA-531] Implement collection sort possibility #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EreMaijala
requested changes
Oct 19, 2023
| @@ -139,7 +139,7 @@ public function toSolrArray(Database $db = null) | |||
|
|
|||
| // Single-valued sequence for sorting | |||
| if (isset($data['hierarchy_sequence'])) { | |||
| $data['hierarchy_sequence_str'] = $data['hierarchy_sequence']; | |||
| $data['hierarchy_sequence_sort_str'] = $this->getSequenceForSort(); | |||
There was a problem hiding this comment.
hierarchy_sequence -kentän luonti on monimutkainen operaatio, eikä pelkän sequencen ottaminen archive:sta tuota oikeaa tulosta kaikissa tapauksissa. Meillä on siis sellaisia lähteitä, joissa arkisto tulee palasina, jolloin sequence ei ole yhtenäinen.
|
tää menee sen verran monimutkaseks et suljen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the name of hierarchy_sequence_str to hierarchy_sequence_sort_str as it seems it has been used as some sorting mechanism.