Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with obfuscated bundles #106

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Build with obfuscated bundles #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
44473fe
Check for bundle and build if exists
simonhamp Sep 5, 2024
42ce4b6
Fix app name setting in the package.json
simonhamp Sep 5, 2024
2646655
Copy the installer icon
simonhamp Sep 5, 2024
a48d16a
Fix styling
simonhamp Sep 5, 2024
1f429ea
Update to latest binaries
simonhamp Sep 5, 2024
7daf9fd
Fix bundle copy
simonhamp Sep 11, 2024
9a02339
Merge branch 'main' into feature/build-with-obfuscated-bundle
simonhamp Nov 12, 2024
8b0e43d
Restore changes from other PR
simonhamp Dec 9, 2024
aeee3fe
Merge branch 'main' into feature/build-with-obfuscated-bundle
simonhamp Dec 18, 2024
0938806
Move trait
simonhamp Dec 10, 2024
ecde43e
Add env file processing in build step
simonhamp Dec 19, 2024
461acb3
Fix styling
simonhamp Dec 19, 2024
bd9419e
Don't copy builds, logs or caches
simonhamp Dec 19, 2024
eccd3b9
Merge branch 'main' into feature/build-with-obfuscated-bundle
simonhamp Dec 26, 2024
3f5996d
Clear the view cache on boot
simonhamp Jan 2, 2025
3e47d81
Merge branch 'main' into feature/build-with-obfuscated-bundle
simonhamp Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 65 additions & 51 deletions resources/js/electron-builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,8 @@ if (isDarwin) {
targetOs = 'mac';
}


let updaterConfig = {};

// We wouldn't need these since its not representing the target platform
console.log("Arch: ", process.arch)
console.log("Platform: ", process.platform)
try {
updaterConfig = process.env.NATIVEPHP_UPDATER_CONFIG;
updaterConfig = JSON.parse(updaterConfig);
Expand All @@ -47,6 +43,8 @@ try {
}

if (isBuilding) {
console.log("Current platform: ", process.platform)
console.log("Current arch: ", process.arch)

console.log();
console.log('===================================================================');
Expand All @@ -61,53 +59,69 @@ if (isBuilding) {

removeSync(appPath);

// As we can't copy into a subdirectory of ourself we need to copy to a temp directory
let tmpDir = mkdtempSync(join(os.tmpdir(), 'nativephp'));

copySync(process.env.APP_PATH, tmpDir, {
overwrite: true,
dereference: true,
filter: (src, dest) => {
let skip = [
// Skip .git and Dev directories
join(process.env.APP_PATH, '.git'),
join(process.env.APP_PATH, 'docker'),
join(process.env.APP_PATH, 'packages'),

// Only needed for local testing
join(process.env.APP_PATH, 'vendor', 'nativephp', 'electron', 'vendor'),
join(process.env.APP_PATH, 'vendor', 'nativephp', 'laravel', 'vendor'),

join(process.env.APP_PATH, 'vendor', 'nativephp', 'php-bin'),
join(process.env.APP_PATH, 'vendor', 'nativephp', 'electron', 'bin'),
join(process.env.APP_PATH, 'vendor', 'nativephp', 'electron', 'resources'),
join(process.env.APP_PATH, 'node_modules'),
join(process.env.APP_PATH, 'dist'),
];

let shouldSkip = false;
skip.forEach((path) => {
if (src.indexOf(path) === 0) {
shouldSkip = true;
}
});

return !shouldSkip;
}
});

copySync(tmpDir, appPath);

// Electron build removes empty folders, so we have to create dummy files
// dotfiles unfortunately don't work.
writeJsonSync(join(appPath, 'storage', 'framework', 'cache', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'framework', 'sessions', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'framework', 'testing', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'framework', 'views', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'app', 'public', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'logs', '_native.json'), {})

removeSync(tmpDir);
let bundle = join(process.env.APP_PATH, 'build', '__nativephp_app_bundle');

if (existsSync(bundle)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existsSync is not imported

copySync(bundle, join(appPath, 'bundle', '__nativephp_app_bundle'));
} else {
// As we can't copy into a subdirectory of ourself we need to copy to a temp directory
let tmpDir = mkdtempSync(join(os.tmpdir(), 'nativephp'));

console.warn('=====================');
console.warn('* * * INSECURE BUILD * * *');
console.warn('Secure app bundle not found! Building with exposed source files.');
console.warn('See https://nativephp.com/docs/publishing/building#security for more details');
console.warn('=====================');

copySync(process.env.APP_PATH, tmpDir, {
overwrite: true,
dereference: true,
filter: (src, dest) => {
let skip = [
// Skip .git and Dev directories
join(process.env.APP_PATH, '.git'),
join(process.env.APP_PATH, 'docker'),
join(process.env.APP_PATH, 'packages'),

// Only needed for local testing
join(process.env.APP_PATH, 'vendor', 'nativephp', 'electron', 'vendor'),
join(process.env.APP_PATH, 'vendor', 'nativephp', 'laravel', 'vendor'),

join(process.env.APP_PATH, 'vendor', 'nativephp', 'php-bin'),
join(process.env.APP_PATH, 'vendor', 'nativephp', 'electron', 'bin'),
join(process.env.APP_PATH, 'vendor', 'nativephp', 'electron', 'resources'),
join(process.env.APP_PATH, 'node_modules'),
join(process.env.APP_PATH, 'dist'),
join(process.env.APP_PATH, 'build'),

join(process.env.APP_PATH, 'storage', 'framework'),
join(process.env.APP_PATH, 'storage', 'logs'),
];

let shouldSkip = false;
skip.forEach((path) => {
if (src.indexOf(path) === 0) {
shouldSkip = true;
}
});

return !shouldSkip;
}
});

copySync(tmpDir, appPath);

// Electron build removes empty folders, so we have to create dummy files
// dotfiles unfortunately don't work.
writeJsonSync(join(appPath, 'storage', 'framework', 'cache', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'framework', 'sessions', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'framework', 'testing', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'framework', 'views', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'app', 'public', '_native.json'), {})
writeJsonSync(join(appPath, 'storage', 'logs', '_native.json'), {})
Comment on lines +116 to +121
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to use outputJsonSync to create any missing directory in path or add additionall call ensureDirSync, but I prefer outputJsonSync


removeSync(tmpDir);
}

console.log();
console.log('Copied app to resources');
Expand Down
Loading
Loading