Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows support and deep linking configuration #158

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

JulianaChiabai
Copy link
Contributor

No description provided.

@simonhamp
Copy link
Member

Thanks for this @JulianaChiabai! Would you mind just providing a brief description and tag any issues this may fix or discussion threads it relates to?

@simonhamp simonhamp merged commit 42026e6 into NativePHP:main Jan 21, 2025
1 check passed
@gwleuverink
Copy link
Contributor

@simonhamp I'm working on fixing tests/builds on PR #153. Just pulled in main and this PR seems to break the npm plugin:build for me.

@SRWieZ
Copy link
Contributor

SRWieZ commented Jan 24, 2025

I can confirm this. This PR uses this.handleDeepLink(), which doesn't appear to be declared.

It should probably replicate what the macOS code does:

app.on("open-url", (event, url) => {
  notifyLaravel("events", {
    event: "\\Native\\Laravel\\Events\\App\\OpenedFromURL",
    payload: [url],
  });
});

And send comandline instead of url

I propose to modify OpenedFromURL to support both and keep one event for the 3 os

class OpenedFromURL implements ShouldBroadcastNow
{
    use Dispatchable, InteractsWithSockets, SerializesModels;

    public function __construct(public ?string $url = null, public ?string $commandLine= null) {}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants