Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mobile/desktop docs #78

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SRWieZ
Copy link
Contributor

@SRWieZ SRWieZ commented Jan 26, 2025

Capture d’écran 2025-01-26 à 23 43 59 Capture d’écran 2025-01-26 à 23 43 46

Copy link
Member

@simonhamp simonhamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the switcher. It may need to be simplified when viewing on mobile, but seems fine for now

My only challenge is with the URLs

routes/web.php Outdated Show resolved Hide resolved
@SRWieZ
Copy link
Contributor Author

SRWieZ commented Jan 27, 2025

Modified as per review.

Also:

  • Emptied the boilerplate of mobile documentation.
  • Created a new variable $platform everywhere $version was available.
  • Fixed a width issue when there was no text on a page (visible in screenshot above).
  • Updated URLs from docs/1/ to docs/desktop/1/ in *.md files.
  • Put a 302 redirect on old URLs (you can change it to 301 when you want; it's just that 301 cache is so hard to clear, I preferred to wait for the full green light).
  • Update SEO title to include platform and version

@SRWieZ SRWieZ requested a review from simonhamp January 27, 2025 16:06
@SRWieZ
Copy link
Contributor Author

SRWieZ commented Feb 1, 2025

Reverted the following fix that made it worse in large screen:

  • Fixed a width issue when there was no text on a page (visible in screenshot above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants