Weekly release 2023-09-25 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jrdh
commented
Sep 25, 2023
jrdh
commented
- Support CKAN 2.10 #81
In CKAN 2.10, they have renamed the IPackageController hooks. This really should have been a major change as it breaks the public API but hey ho here we are. To accommodate this while also supporting CKAN 2.9, I have renamed the hook functions we were using to their new CKAN 2.10 variants and then added functions which just call those functions which have the old CKAN 2.9 names. This is ok in this extension as we're not using any interfaces which have a name clash with the old names. The old names should be removed as soon as we stop supporting CKAN 2.9 cause it's ugly stuff.
This commit contains a container rename, the base container isn't ckan anymore as there are now two test running containers: latest which runs tests on the ckantest latest image (currently 2.9.9) and next which run tests on the ckantest next image (currently 2.10.1).
In CKAN 2.9 the package controller hook functions are called (for example) after_create but in CKAN 2.10 they've changed to (for example) after_dataset_create. These tests confirm a few things to do with these functions, but mainly they've been added to confirm that on 2.9 and 2.10 the hooks work correctly.
Support CKAN 2.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.