Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mongodb_user): Fix MongoDb users import and minor errors #485

Merged
merged 8 commits into from
Jan 7, 2025
Merged

fix(mongodb_user): Fix MongoDb users import and minor errors #485

merged 8 commits into from
Jan 7, 2025

Conversation

youngmn
Copy link
Collaborator

@youngmn youngmn commented Nov 25, 2024 •
edited
Loading

Related

#460

Description

  • FIX import and minor errors
  • Change argument from mongodb_user_list to mongodb_user_set
  • DOCS : Modify the list of arguments and attributes

AccTest results


=== RUN   TestAccResourceNcloudMongoDbUsers_vpc_update
--- PASS: TestAccResourceNcloudMongoDbUsers_vpc_update (698.60s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ncloud/internal/service/mongodb	699.382s

=== RUN   TestAccDataSourceNcloudMongoDbUsers_vpc_basic
--- PASS: TestAccDataSourceNcloudMongoDbUsers_vpc_basic (729.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ncloud/internal/service/mongodb	730.122s

@youngmn youngmn requested a review from wonchulee as a code owner November 25, 2024 23:33
@youngmn youngmn self-assigned this Nov 29, 2024
wonchulee
wonchulee reviewed Dec 10, 2024
View reviewed changes
docs/data-sources/mongodb_users.md Outdated Show resolved Hide resolved
internal/service/mongodb/mongodb_users.go Outdated Show resolved Hide resolved
internal/service/mongodb/mongodb_users.go Outdated Show resolved Hide resolved
internal/service/mongodb/mongodb_users.go Outdated Show resolved Hide resolved
internal/service/mongodb/mongodb_users_data_source.go Outdated Show resolved Hide resolved
wonchulee
wonchulee reviewed Jan 3, 2025
View reviewed changes
internal/service/mongodb/mongodb_users.go Show resolved Hide resolved
internal/service/mongodb/mongodb_users.go Outdated Show resolved Hide resolved
internal/service/mongodb/mongodb_users.go Outdated Show resolved Hide resolved
internal/service/mongodb/mongodb_users.go Show resolved Hide resolved
@wonchulee wonchulee merged commit 58d3fcf into main Jan 7, 2025
4 checks passed
@wonchulee wonchulee deleted the fix/mongodb_user branch January 7, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonchulee wonchulee wonchulee approved these changes

Assignees

@youngmn youngmn

Labels
documentation enhancement FRAMEWORK VPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngmn @wonchulee