Skip to content

Commit

Permalink
Merge pull request #594 from NeTEx-CEN/remove_externalelements
Browse files Browse the repository at this point in the history 
Remove External entities with for VDV compatibility in favor of Priva…
  • Loading branch information
@Aurige
Aurige authored Jun 26, 2024
2 parents 2583637 + 8369fd7 commit 9b93bf6
Show file tree
Hide file tree
Showing 10 changed files with 47 additions and 28 deletions.
21 changes: 14 additions & 7 deletions examples/standards/tap_tsi/TAP-TSDUPD-example1.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,11 @@ TapTsi B.4.7009
</SiteFrame>
<ServiceFrame version="any" id="TSDUPD-example">
<Name>Location / STation TSDUPD example </Name>
<directions>
<Direction version="uic" id="54"/>
<Direction version="uic" id="68"/>
<Direction version="uic" id="84"/>
</directions>
<scheduledStopPoints>
<ScheduledStopPoint version="any" id="uic:007300101">
<!-- Narrative: Declares the timetable stop -->
Expand Down Expand Up @@ -473,11 +478,13 @@ TapTsi B.4.7009
<MinimumTransferTime>PT8M</MinimumTransferTime>
<DistributorFilter>
<OperatorRef versionRef="EXTERNAL" ref="uic:54"/>
<LineInDirectionRef>
<ExternalDirectionRef type="uicType" ref="54"/>
<!-- TapTsi B.4.7009 54 Talgo ! -->
<!-- NB Work around to handle this case NeTEX needs to add additional filter -->
</LineInDirectionRef>
<linesInDirectionRefs>
<LineInDirectionRef>
<DirectionRef ref="54" version="uic"/>
<!-- TapTsi B.4.7009 54 Talgo ! -->
<!-- NB Work around to handle this case NeTEX needs to add additional filter -->
</LineInDirectionRef>
</linesInDirectionRefs>
<ScheduledStopPointRef version="any" ref="uic:007300101"/>
</DistributorFilter>
</InterchangeRule>
Expand Down Expand Up @@ -512,7 +519,7 @@ TapTsi B.4.7009
<TransportMode>rail</TransportMode>
<OperatorRef versionRef="EXTERNAL" ref="uic:1073"/>
<LineInDirectionRef>
<ExternalDirectionRef type="uicType" ref="68"/>
<DirectionRef version="uic" ref="68"/>
<!-- TapTsi B.4.7009 68 Internationa; -->
<!-- NB Work around to handle this case GAP NeTEX needs to add additional filter for Product /service type-->
</LineInDirectionRef>
Expand All @@ -522,7 +529,7 @@ TapTsi B.4.7009
<TransportMode>rail</TransportMode>
<OperatorRef versionRef="EXTERNAL" ref="uic:1180"/>
<LineInDirectionRef>
<ExternalDirectionRef type="uicType" ref="84"/>
<DirectionRef version="uic" ref="84"/>
<!-- TapTsi B.4.7009 84 Regional Train; -->
<!-- NB Work around to handle this case GAP NeTEX needs to add additional filter for Product /service type-->
</LineInDirectionRef>
Expand Down
20 changes: 16 additions & 4 deletions examples/standards/vdv452/timetable/NeTEx VDV Example.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2377,16 +2377,25 @@
</InfrastructureFrame>
<ServiceFrame id="dummy" version="any">
<directions>
<Direction version="ext" id="VAG009A"/>
<Direction id="DIR_1" version="1">
<keyList>
<KeyValue>
<Key>ExternalDirectionRef</Key>
<!-- or with PrivateCode like in the second Direction -->
<Value>1</Value>
</KeyValue>
</keyList>
<Name>Direction A</Name>
<ShortName>A</ShortName>
<ExternalDirectionRef ref="1"/>
<DirectionType>inbound</DirectionType>
</Direction>
<Direction id="DIR_2" version="1">
<privateCodes>
<PrivateCode>2</PrivateCode>
</privateCodes>
<Name>Direction B</Name>
<ShortName>B</ShortName>
<ExternalDirectionRef ref="2"/>
<DirectionType>outbound</DirectionType>
</Direction>
</directions>
Expand Down Expand Up @@ -3436,6 +3445,9 @@
</Route>
</routes>
<lines>
<Line version="ext" id="VAG009">
<Name>VAG009</Name>
</Line>
<Line id="LI_2" version="1">
<privateCodes>
<PrivateCode>3</PrivateCode>
Expand Down Expand Up @@ -108122,8 +108134,8 @@
</timings>
<FeederFilter>
<LineInDirectionRef>
<ExternalLineRef ref="VAG009"/>
<ExternalDirectionRef ref="VAG009A"/>
<LineRef version="ext" ref="VAG009"/>
<DirectionRef version="ext" ref="VAG009A"/>
</LineInDirectionRef>
</FeederFilter>
<DistributorFilter>
Expand Down
2 changes: 1 addition & 1 deletion xsd/netex_framework/netex_genericFramework/netex_organisation_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element name="ExternalOperatorRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the OPERATOR. Specifically for use in AVMS systems. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the OPERATOR. Specifically for use in AVMS systems. For VDV compatibility. DEPRECATED - use PrivateCode -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
</xsd:sequence>
Expand Down
4 changes: 2 additions & 2 deletions xsd/netex_framework/netex_reusableComponents/netex_serviceRestrictions_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -609,12 +609,12 @@ Rail transport, Roads and Road transport
</xsd:complexType>
<xsd:group name="TypeOfProductCategoryGroup">
<xsd:annotation>
<xsd:documentation>Elements for a TYPE OF PRODUCT CATEGORY.</xsd:documentation>
<xsd:documentation>Elements for a TYPE OF PRODUCT CATEGORY.</xsd:documentation>
</xsd:annotation>
<xsd:sequence>
<xsd:element name="ExternalProductCategoryRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the PRODUCT CATEGORY. Specifically for use in AVMS systems that require an alias, if code is different from main identifier. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the PRODUCT CATEGORY. Specifically for use in AVMS systems that require an alias, if code is different from main identifier. For VDV compatibility. DEPRECATED - use privateCodes -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="Presentation" type="PresentationStructure" minOccurs="0">
Expand Down
8 changes: 4 additions & 4 deletions xsd/netex_part_1/part1_networkDescription/netex_line_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element name="ExternalLineRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the LINE specifically for use in AVMS systems. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the LINE specifically for use in AVMS systems. For VDV compatibility. DEPRECATED - use privateCodes -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
</xsd:sequence>
Expand Down Expand Up @@ -473,7 +473,7 @@ Rail transport, Roads and Road transport
<xsd:element ref="TypeOfLineRef" minOccurs="0"/>
<xsd:element name="ExternalProductCategoryRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An default product classification for all journeys of the lin e for use in AVMS systems. For VDV compatibility. +v1.1</xsd:documentation>
<xsd:documentation>An default product classification for all journeys of the lin e for use in AVMS systems. For VDV compatibility. +v1.1. DEPRECATED - use privateCodes -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element ref="TypeOfProductCategoryRef" minOccurs="0"/>
Expand Down Expand Up @@ -976,12 +976,12 @@ Rail transport, Roads and Road transport
<xsd:element ref="DirectionRef" minOccurs="0"/>
<xsd:element name="ExternalLineRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Alternative LINE Reference for AVMS system.</xsd:documentation>
<xsd:documentation>Alternative LINE Reference for AVMS system. DEPRECATED - v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="ExternalDirectionRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Alternative DIRECTION Reference for AVMS system.</xsd:documentation>
<xsd:documentation>Alternative DIRECTION Reference for AVMS system. DEPRECATED -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
</xsd:sequence>
Expand Down
2 changes: 1 addition & 1 deletion xsd/netex_part_1/part1_networkDescription/netex_route_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ Rail transport, Roads and Road transport
<xsd:sequence>
<xsd:element name="ExternalDirectionRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the DIRECTION specifically for use in AVMS systems. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the DIRECTION specifically for use in AVMS systems. For VDV compatibility. DEPRECATED - use privateCodes. -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element ref="DirectionType" minOccurs="0"/>
Expand Down
4 changes: 2 additions & 2 deletions xsd/netex_part_1/part1_tacticalPlanning/netex_servicePattern_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element name="ExternalStopPointRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the STOP POINT. pecifically for use in AVMS systems that require an alias, if. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the STOP POINT. pecifically for use in AVMS systems that require an alias, if. For VDV compatibility. DEPRECATED - use privateCodes. -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
</xsd:sequence>
Expand Down Expand Up @@ -555,7 +555,7 @@ Rail transport, Roads and Road transport
<xsd:sequence>
<xsd:element name="ExternalConnectionLinkRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the CONNECTION link Specifically for use in AVMS systems that require an alias, if. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the CONNECTION link Specifically for use in AVMS systems that require an alias, if. For VDV compatibility. DEPRECATED - use privateCodes. -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="From" type="ConnectionEndStructure" minOccurs="0">
Expand Down
6 changes: 3 additions & 3 deletions xsd/netex_part_2/part2_journeyTimes/netex_datedVehicleJourney_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -205,12 +205,12 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element ref="UicOperatingPeriod" minOccurs="0">
<xsd:annotation>
<xsd:documentation>** DEPRECATED ** not to be used - left available only to avoid breaking compatibility with old rail datasets</xsd:documentation>
<xsd:documentation>** DEPRECATED ** not to be used - left available only to avoid breaking compatibility with old rail datasets -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="ExternalDatedVehicleJourneyRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies theDATED VEHICLE JOURNEY. Specifically for use in AVMS systems. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies theDATED VEHICLE JOURNEY. Specifically for use in AVMS systems. For VDV compatibility. DEPRECATED. -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="DatedJourneyPatternRef" type="JourneyPatternRefStructure" minOccurs="0">
Expand All @@ -220,7 +220,7 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element ref="DriverRef" minOccurs="0">
<xsd:annotation>
<xsd:documentation>** DEPRECATED ** not to be used - It is expected that the driver's DUTY refer the DatedJourneyPattern, not the way arround !</xsd:documentation>
<xsd:documentation>** DEPRECATED ** not to be used - It is expected that the driver's DUTY refer the DatedJourneyPattern, not the way arround ! -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
</xsd:sequence>
Expand Down
6 changes: 3 additions & 3 deletions xsd/netex_part_2/part2_journeyTimes/netex_interchange_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -424,17 +424,17 @@ Rail transport, Roads and Road transport
</xsd:element>
<xsd:element ref="PrivateCode" minOccurs="0">
<xsd:annotation>
<xsd:documentation>DEPRECATED - use privateCodes</xsd:documentation>
<xsd:documentation>DEPRECATED - use privateCodes. -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="ExternalInterchangeRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the INTERCHANGE. Specifically for use in AVMS systems. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the INTERCHANGE. Specifically for use in AVMS systems. For VDV compatibility. DEPRECATED - use privateCodes. -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="ConnectionRef" type="ConnectionRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>Reference to a CONNECTION Link over which the INTERCHANEG takes place.</xsd:documentation>
<xsd:documentation>Reference to a CONNECTION Link over which the INTERCHANGE takes place.</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element name="Priority" type="InterchangePriorityType" minOccurs="0">
Expand Down
2 changes: 1 addition & 1 deletion xsd/netex_part_2/part2_journeyTimes/netex_journey_version.xsd
View file
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ Rail transport, Roads and Road transport
<xsd:element ref="TransportSubmode" minOccurs="0"/>
<xsd:element name="ExternalVehicleJourneyRef" type="ExternalObjectRefStructure" minOccurs="0">
<xsd:annotation>
<xsd:documentation>An alternative code that uniquely identifies the JOURNEY. Specifically for use in AVMS systems. For VDV compatibility.</xsd:documentation>
<xsd:documentation>An alternative code that uniquely identifies the JOURNEY. Specifically for use in AVMS systems. For VDV compatibility. DEPRECATED - use privateCodes. -v2.0</xsd:documentation>
</xsd:annotation>
</xsd:element>
<xsd:element ref="TypeOfProductCategoryRef" minOccurs="0"/>
Expand Down

0 comments on commit 9b93bf6

Please sign in to comment.