Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant sequence #287

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Remove redundant sequence #287

merged 1 commit into from
Dec 14, 2023

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Jan 26, 2022 •
edited
Loading

For discussion: #286

@skinkie skinkie added the enhancement non semantic enhacement: technical enhancement, etc. label Jan 26, 2022
@skinkie skinkie self-assigned this Jan 26, 2022
@ue71603
Copy link
Contributor

ue71603 commented Apr 12, 2022

@skinkie How do we progress?

@skinkie
Copy link
Contributor Author

skinkie commented Apr 12, 2022

@ue71603 @Aurige mentioned this needs to be checked for every instance where this happens in EA. I have obviously sent him every instance...

ue71603
ue71603 approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@ue71603 ue71603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was only one to be found? Then ok

@ue71603 ue71603 mentioned this pull request Apr 20, 2022
Open
@skinkie
Copy link
Contributor Author

skinkie commented Apr 20, 2022

There was only one to be found? Then ok

No, no, no... hunderds... I'll mail ;-)

@ue71603
Copy link
Contributor

ue71603 commented Apr 20, 2022

I found it in the issue. But we still could finalise this one?

@ue71603
Copy link
Contributor

ue71603 commented Nov 21, 2023

@skinkie @Aurige
If this should be done:
(1) Say if we do it?
(2) List to be provided here
(3) @trurlurl may start working on it.

@Aurige
Copy link
Contributor

Aurige commented Nov 21, 2023

It was discussed in one of the meetings, and the decision was to correct this kind of unnecessary sequence when we work on something related (by opportunity): it is too much work (and time) to check all of them one by one, and it does not harm.

@ue71603 ue71603 force-pushed the remove_redundant_sequence branch from 7176c7a to c209788 Compare December 14, 2023 16:36
@ue71603 ue71603 marked this pull request as ready for review December 14, 2023 16:38
@skinkie skinkie merged commit b95f280 into master Dec 14, 2023
1 check passed
@skinkie skinkie deleted the remove_redundant_sequence branch December 14, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@ue71603 ue71603 ue71603 approved these changes

@Aurige Aurige Aurige approved these changes

@nick-knowles nick-knowles Awaiting requested review from nick-knowles

@syversenkr syversenkr Awaiting requested review from syversenkr

Assignees

@skinkie skinkie

Labels
enhancement non semantic enhacement: technical enhancement, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skinkie @ue71603 @Aurige @trurlurl