Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh driver permit #545

Merged
merged 17 commits into from
Nov 21, 2023
Merged

Enh driver permit #545

merged 17 commits into from
Nov 21, 2023

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Nov 3, 2023

@nick-knowles targeted in #408 master, should this be master or next?

skinkie and others added 8 commits September 27, 2023 21:47
@skinkie @ue71603
Update netex_nm_vehicleMeetingPointAssignment_support.xsd (#506)
645503d 
Co-authored-by: ue71603 <[email protected]>
@skinkie @ue71603
@Aurige @github-actions @trurlurl
Fix improve mode (#507)
9ffc9a8 
* First draft of the clean up of MODE

* Better explanations in VEHICLE MODE
* AccessMode now works TRANSFERs and OTHER LEG (for OJP)
* Some depreciations

* added a mode to Connection

* Update netex_mode_support.xsd

Deprecated not Depreciated ;-)

* Update netex_submode_version.xsd

Deprecated not Depreciated ;-)

* Apply suggestions from code review

* Lint and update documentation tables

* Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd

Co-authored-by: trurlurl <[email protected]>

* Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd

Co-authored-by: trurlurl <[email protected]>

---------

Co-authored-by: ue71603 <[email protected]>
Co-authored-by: Christophe Duquesne <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: trurlurl <[email protected]>
@skinkie @ue71603 @github-actions
Fix passenger information equipment list (#510)
91c3815 
* The connection exists in the documentation, but was not done in the xsd

NeTEx part 1, figure 628

* Fixed according to Christophe's proposal

* Apply suggestions from code review

* Update xsd/netex_part_1/part1_tacticalPlanning/netex_passengerInformationEquipment_version.xsd

* Lint and update documentation tables

---------

Co-authored-by: ue71603 <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@skinkie
Fix typo's (#511)
fff853e
@skinkie
Introduce VAT (#516)
6ae5cc4 
* Introduce VAT number
@skinkie @ue71603 @github-actions
Removing duplicate enumeration (thanks to David) (#509)
7a1af73 
* Removing duplicate enumeration (thanks to David)

btw something is wrong with  xsd\netex_part_1\part1_ifopt\netex_ifopt_equipmentAccess_support.xsd in next

* Lint and update documentation tables

* Update xsd/netex_framework/netex_reusableComponents/netex_nm_equipmentEnergy_support.xsd

Co-authored-by: Matthias Günter <[email protected]>

---------

Co-authored-by: ue71603 <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@nick-knowles @skinkie
enhancement-TMTC-add ACCEPTED DRIVER PERMITs
aaff0a6 
Add ACCEPTED DRIVER PERMITS to VEHICEL TYpe
@skinkie
lint
7c8804b
@skinkie skinkie added enhancement non semantic enhacement: technical enhancement, etc. needs documentation update The NeTEx document needs to be updated labels Nov 3, 2023
@skinkie skinkie self-assigned this Nov 3, 2023
@Aurige
Copy link
Contributor

Aurige commented Nov 6, 2023

@nick-knowles targeted in #408 master, should this be master or next?

Next is obviously better since it is an enhancement

@skinkie skinkie changed the base branch from master to next November 6, 2023 12:08
@skinkie
Copy link
Contributor Author

skinkie commented Nov 6, 2023

@ue71603 @trurlurl the documentation under acceptedDriverPermits is likely wrong too, right?

Aurige
Aurige reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@Aurige Aurige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just reviewing netex_vehicle_type_xxx.xsd (everything else seems to come from a stack of previous PR initially target to main, but now brought back to next, right ?)

xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Outdated Show resolved Hide resolved
@Aurige
Copy link
Contributor

Aurige commented Nov 10, 2023

The AcceptedDriverPermitRef is defined but not used anywhere .. also the AcceptedDriverPermit is a DataManagedObject so it would be Ok to keep this possibility for possible future use if you prefer (but I don't see much use case for us, I personally would rather remove it)

@skinkie skinkie merged commit 80abd49 into next Nov 21, 2023
1 check passed
@skinkie skinkie deleted the enh_driver_permit branch November 21, 2023 18:27
@Aurige
Copy link
Contributor

Aurige commented Jul 18, 2024

Part 1 and Part 5 document updated

@Aurige Aurige added document has been updated NeTEx Document already updated and removed needs documentation update The NeTEx document needs to be updated labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl requested changes

@ue71603 ue71603 ue71603 approved these changes

@Aurige Aurige Aurige approved these changes

@nick-knowles nick-knowles Awaiting requested review from nick-knowles

Assignees

@skinkie skinkie

Labels
document has been updated NeTEx Document already updated enhancement non semantic enhacement: technical enhancement, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skinkie @Aurige @ue71603 @trurlurl @nick-knowles