Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test crossing equipment example #548

Closed
wants to merge 10 commits into from

Conversation

skinkie
Copy link
Contributor

@skinkie skinkie commented Nov 4, 2023

Fix #361

@skinkie skinkie added the example An additional example label Nov 4, 2023
@skinkie skinkie self-assigned this Nov 4, 2023
@skinkie
Copy link
Contributor Author

skinkie commented Nov 6, 2023

@ue71603 that is fine for me, but then the entire example needs to be changed, not the stuff I changed to have a consistend versionRef, and not in this pull request, because this only adds your example on top of #547

@skinkie
Copy link
Contributor Author

skinkie commented Nov 7, 2023

@ue71603 @Aurige this one is next.

@Aurige
Copy link
Contributor

Aurige commented Nov 7, 2023

I don't fully get that example: huge commented part, one single CrossingEquipement that is not used, a lot of declared but not used objects, xsi:schemaLocation on a local drive ... what is the purpose of this example ?

@Aurige
Copy link
Contributor

Aurige commented Nov 7, 2023

Also the example does not validate in 'next' due to level that now requires a mandatory RelativeLevelOrder ! I don't remember which PR added this RelativeLevelOrder , and do we really want it mandatory ?

@ue71603
Copy link
Contributor

ue71603 commented Nov 8, 2023

I don't fully get that example: huge commented part, one single CrossingEquipement that is not used, a lot of declared but not used objects, xsi:schemaLocation on a local drive ... what is the purpose of this example ?

It tests the CrossingExample content. I think it is better than no example at all.

@ue71603
Copy link
Contributor

ue71603 commented Nov 8, 2023

RelativeLevelOrder

It was done in
PullRequest: #410 (merged)
Branch: EPIAP
Documention: updated in section 9.2.5

If we don't want it mandatory, then we can update it. But we had a length discussion. See also @Joostb61 @duexw

@Aurige
Copy link
Contributor

Aurige commented Nov 9, 2023

Thanks @ue71603 for pointing #410 ... it is properly done in EPIAP and all fine for me:
image

But for some reason, it is also in 'next'... but not as nicely ! And all the examples using level in next were update with an additional RelativeLevelOrder, which is not great since this RelativeLevelOrder is not always meaningful.
image

@skinkie
Copy link
Contributor Author

skinkie commented Nov 9, 2023

Is the difference in rendering meaning minOccurs.

@Aurige
Copy link
Contributor

Aurige commented Nov 9, 2023

Yes, it should have minOccurs=0 (as is the EPIAP branch)

@skinkie
Copy link
Contributor Author

skinkie commented Nov 9, 2023

Yes, it should have minOccurs=0 (as is the EPIAP branch)

For non XMLspy users as me and @Joostb61 it is not directly obvious ;)

@ue71603
Copy link
Contributor

ue71603 commented Nov 24, 2023

So I guess, we can merge it here (needs approval) from Christophe. I will do a small PR in next so that the minOccur is already there (otherwise it will happen, when we merge the branches)

See also #559

@Aurige
Copy link
Contributor

Aurige commented Nov 28, 2023

The example contains a 2200 lines fully commented ServiceFrame: is it for purpose, or can we just remove it ?

@ue71603
Copy link
Contributor

ue71603 commented Nov 28, 2023

If you want to reduce it to the max, go ahead :-)

@ue71603
Copy link
Contributor

ue71603 commented Nov 28, 2023

shortened it now

I got the following error due versionRef between some elements were different. In my perspective this might actually show an actual bug. For now I resolve it.

element OperatorRef: Schemas validity error : Element '{http://www.netex.org.uk/netex}OperatorRef', attribute 'ref': The XPath '@ref' of a field of keyref identity-constraint '{http://www.netex.org.uk/netex}Operator_KeyRef' evaluates to a node-set with more than one member.
@ue71603 ue71603 force-pushed the add_test_crossing_equipment_example branch from 89aedfc to 96e7819 Compare December 1, 2023 08:31
@ue71603 ue71603 added this to the netex_1.3 milestone Dec 1, 2023
@ue71603
Copy link
Contributor

ue71603 commented Dec 14, 2023

redone here: #611

@ue71603 ue71603 closed this Dec 14, 2023
@skinkie skinkie deleted the add_test_crossing_equipment_example branch November 19, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example An additional example
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants