-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test crossing equipment example #548
Conversation
examples/functions/fares/ENTUR-SchoolTwiceADayTripCarnet_2020120.xml
Outdated
Show resolved
Hide resolved
examples/functions/fares/ENTUR-SchoolTwiceADayTripCarnet_2020120.xml
Outdated
Show resolved
Hide resolved
examples/functions/fares/ENTUR-SchoolTwiceADayTripCarnet_2020120.xml
Outdated
Show resolved
Hide resolved
examples/functions/fares/ENTUR-SchoolTwiceADayTripCarnet_2020120.xml
Outdated
Show resolved
Hide resolved
examples/functions/fares/ENTUR-SchoolTwiceADayTripCarnet_2020120.xml
Outdated
Show resolved
Hide resolved
I don't fully get that example: huge commented part, one single CrossingEquipement that is not used, a lot of declared but not used objects, xsi:schemaLocation on a local drive ... what is the purpose of this example ? |
Also the example does not validate in 'next' due to level that now requires a mandatory RelativeLevelOrder ! I don't remember which PR added this RelativeLevelOrder , and do we really want it mandatory ? |
It tests the CrossingExample content. I think it is better than no example at all. |
Thanks @ue71603 for pointing #410 ... it is properly done in EPIAP and all fine for me: But for some reason, it is also in 'next'... but not as nicely ! And all the examples using level in next were update with an additional RelativeLevelOrder, which is not great since this RelativeLevelOrder is not always meaningful. |
Is the difference in rendering meaning minOccurs. |
Yes, it should have minOccurs=0 (as is the EPIAP branch) |
For non XMLspy users as me and @Joostb61 it is not directly obvious ;) |
So I guess, we can merge it here (needs approval) from Christophe. I will do a small PR in next so that the minOccur is already there (otherwise it will happen, when we merge the branches) See also #559 |
The example contains a 2200 lines fully commented ServiceFrame: is it for purpose, or can we just remove it ? |
If you want to reduce it to the max, go ahead :-) |
shortened it now |
I got the following error due versionRef between some elements were different. In my perspective this might actually show an actual bug. For now I resolve it. element OperatorRef: Schemas validity error : Element '{http://www.netex.org.uk/netex}OperatorRef', attribute 'ref': The XPath '@ref' of a field of keyref identity-constraint '{http://www.netex.org.uk/netex}Operator_KeyRef' evaluates to a node-set with more than one member.
89aedfc
to
96e7819
Compare
redone here: #611 |
Fix #361